[6/6] build: common/static/css/xmodule -> xmodule/static/css - #32291
Merged
kdmccormick merged 1 commit intoJun 20, 2023
Conversation
This was referenced May 23, 2023
kdmccormick
force-pushed
the
kdmccormick/xmodule-static-css
branch
from
May 23, 2023 20:15
bacfc5a to
fcdb84b
Compare
kdmccormick
force-pushed
the
kdmccormick/xmodule-static-css
branch
3 times, most recently
from
May 23, 2023 20:22
c522ca3 to
47e142b
Compare
kdmccormick
force-pushed
the
kdmccormick/xmodule-static-css
branch
from
June 6, 2023 13:48
47e142b to
fb63433
Compare
kdmccormick
marked this pull request as ready for review
June 6, 2023 13:48
kdmccormick
force-pushed
the
kdmccormick/xmodule-static-css
branch
2 times, most recently
from
June 14, 2023 16:46
16185b0 to
315d125
Compare
feanil
approved these changes
Jun 14, 2023
feanil
left a comment
feanil
left a comment
Contributor
There was a problem hiding this comment.
One small doc thing but then I think this is good to go.
kdmccormick
force-pushed
the
kdmccormick/xmodule-static-css
branch
4 times, most recently
from
June 16, 2023 14:46
eb2f650 to
81b5bf1
Compare
Now that all XModule SCSS is located in xmodule/static/sass, it would make sense to co-locate the CSS there as well. We also add a README to explain the purpose of this new folder. In the future, we will move xmodule/js and xmodule/assets into xmodule/static as well. Part of: openedx#32292
kdmccormick
force-pushed
the
kdmccormick/xmodule-static-css
branch
from
June 16, 2023 14:46
81b5bf1 to
46511d2
Compare
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
kdmccormick
added a commit
that referenced
this pull request
Jun 21, 2023
This reverts commit 5671dab.
Member
Author
|
Potential issue identified on studio.edx.org, prepping a revert here: #32526 |
kdmccormick
added a commit
that referenced
this pull request
Jun 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supporting information
This the final PR in a series:
The previous PR is:
The next series of PRs will be here:
Description
Now that all XModule SCSS is located in xmodule/static/sass,
it would make sense to co-locate the CSS there as well.
We also add a README to explain the purpose of this folder.
In the future, we will move xmodule/js and xmodule/assets
into xmodule/static.
Part of: #31624
Testing Instructions
Deadline
Medium urgency.