Skip to content

test: remove unused helper functions from test_views.py - #32559

Merged
feanil merged 2 commits into
openedx:masterfrom
raju249:31696-unused-helper-functions
Jul 3, 2023
Merged

test: remove unused helper functions from test_views.py#32559
feanil merged 2 commits into
openedx:masterfrom
raju249:31696-unused-helper-functions

Conversation

@raju249

@raju249 raju249 commented Jun 23, 2023 •
edited
Loading

Copy link
Copy Markdown

Description

Resolves #31696

Deletes two unused helper functions from lms/djangoapps/teams/tests/test_views.py.

Supporting information

NA

Testing instructions

Running lms/djangoapps/teams/tests/test_views.py should pass as expected before this change.

Deadline

None

Other information

NA

@openedx-webhooks

openedx-webhooks commented Jun 23, 2023 •
edited
Loading

Copy link
Copy Markdown

Thanks for the pull request, @raju249! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 23, 2023
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jun 23, 2023
@e0d e0d changed the title Remove unused helper functions from test_views.py. Remove unused helper functions from test_views.py Jun 26, 2023
@e0d

e0d commented Jun 26, 2023

Copy link
Copy Markdown
Contributor

@raju249 We need to have a CLA on file for you before we can accept this contribution, take a look at the instructions above.

Also, I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard?

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jun 26, 2023
@e0d e0d mentioned this pull request Jun 26, 2023
Closed
@raju249

raju249 commented Jun 26, 2023

Copy link
Copy Markdown
Author

Thanks @e0d

Just fixing my commit messages. Regarding CLA, I am awaiting a reply from the team, I have signed on my side. Over email conversation, I got to know that the legal team member is on leave for this week...

I am fine with keeping this and the other PR open until its complete. 👍

@raju249
raju249 force-pushed the 31696-unused-helper-functions branch from e81cb11 to 156f2fd Compare June 26, 2023 14:02
@raju249

raju249 commented Jun 26, 2023

Copy link
Copy Markdown
Author

Ok, I think I messed up with merge and rebase. Let me rectify.

@raju249
raju249 force-pushed the 31696-unused-helper-functions branch from 4bd5cce to 927a8e4 Compare June 26, 2023 14:38
@raju249 raju249 changed the title Remove unused helper functions from test_views.py test: remove unused helper functions from test_views.py Jun 26, 2023
@raju249

raju249 commented Jun 26, 2023

Copy link
Copy Markdown
Author

@e0d - I have fixed the commit messages from the direction mentioned here.

I have also rebased to latest master. I also just got a confirmation on email that the legal team member is back at work and will take care of the CLA today.

@raju249

raju249 commented Jun 27, 2023

Copy link
Copy Markdown
Author

@e0d - CLA is complete. Can you or someone else please help me with a review on this PR?

@raju249 raju249 changed the title test: remove unused helper functions from test_views.py test: remove unused helper functions from test_views.py Jun 28, 2023
@raju249 raju249 changed the title test: remove unused helper functions from test_views.py test: remove unused helper functions from test_views.py Jun 28, 2023
Rajendra Kadam
test: remove unused helper functions from test_views.py
ad3b561 
Since they were not used anywhere, it is ideal to delete them.

It would be redundant to keep them.
@raju249
raju249 force-pushed the 31696-unused-helper-functions branch from a104f26 to ad3b561 Compare June 28, 2023 09:06
@raju249

raju249 commented Jun 30, 2023

Copy link
Copy Markdown
Author

@e0d - can you help re-run the pipeline, please?

@e0d

e0d commented Jun 30, 2023

Copy link
Copy Markdown
Contributor

@raju249 I've pulled in changes from master as a merge commit which will update your branch and cause the tests to be re-run.

@raju249

raju249 commented Jul 2, 2023

Copy link
Copy Markdown
Author

Thanks @e0d

@feanil / @nedbat - Mind taking a look at this PR, please?

feanil
feanil approved these changes Jul 3, 2023
View reviewed changes

@feanil feanil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks like these aren't used in platform testing anywhere.

@feanil

feanil commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

I'll coordinate merging.

@feanil
feanil merged commit 286a9cd into openedx:master Jul 3, 2023
@openedx-webhooks

openedx-webhooks commented Jul 3, 2023

Copy link
Copy Markdown

@raju249 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot

edx-pipeline-bot commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

edx-pipeline-bot commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot

edx-pipeline-bot commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot

edx-pipeline-bot commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

edx-pipeline-bot commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot

edx-pipeline-bot commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@kdmccormick kdmccormick mentioned this pull request Jul 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@feanil feanil feanil approved these changes

Assignees

No one assigned

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

What to do with "get_user_course_specific_teams_list" ?

6 participants

@raju249 @openedx-webhooks @e0d @feanil @edx-pipeline-bot @mphilbrick211