Docker multi-arch images push for linux/amd64, linux/arm64 - #32686
Conversation
| check-types: ## run static type-checking tests | ||
| mypy | ||
|
|
||
| docker_build: |
There was a problem hiding this comment.
Is it possible to keep the separation between build and push steps? I can envision the need to iterate on the build process locally for development/debugging, without wanting to push the results up to Docker Hub.
jmbowman
left a comment
jmbowman
left a comment
There was a problem hiding this comment.
The last remaining concern is "will this slow down production deployments?" It doesn't look like GoCD is checking the status of the "Push Docker Images" workflow after merges to master, but we're not sure why and hence not super confident in that. Maybe you and the team can help figure out if this job is on the critical path for stage and production deployments or not? (It will be eventually when we switch to running edx-platform in Kubernetes, but we have some time to optimize before then.)
| DOCKERHUB_PASSWORD: ${{ secrets.DOCKERHUB_PASSWORD }} | ||
| DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }} | ||
| run : make docker_push | ||
| DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }} |
There was a problem hiding this comment.
Accidental trailing whitespace?
UsamaSadiq
left a comment
UsamaSadiq
left a comment
There was a problem hiding this comment.
Some minor suggestions otherwise we can go ahead and merge the PR. One hour Docker image building time won't affect our normal deployments pipeline for now so we can go ahead with the merge now and create a follow up issue for the optimisation.
d5cdbc7 to
f1eb67c
Compare
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
4 participants
Description:
In this PR i updated github action for docker multi-arch (linux/amd64, linux/arm64) push
Ticket:
Arbi-BOM (view)