build: npm run compile-sass (WIP) - #32722
Closed
kdmccormick wants to merge 6 commits into
Closed
Conversation
8 tasks
kdmccormick
force-pushed
the
kdmccormick/compile-sass-py
branch
from
July 14, 2023 15:53
883d71f to
d31841a
Compare
kdmccormick
changed the title
npm run compile-sassnpm run compile-sass (WIP)
kdmccormick
force-pushed
the
kdmccormick/compile-sass-py
branch
from
July 14, 2023 19:57
d31841a to
b2a5901
Compare
…RE-MERGE) Re-merge of 4b64d83 The commit after this one contains the fix for the issue that led to the revert.
Two fixes: * In the Dockerfile, add copy-node-modules.sh before `npm install`, since it is needed by the new postinstall hook. * In paver/assets.py, run copy-node-modules.sh for backwards com- patibility, just for cases where `SKIP_NPM_INSTALL` is enabled (which would prevent our new postinstall hook from running automatically!). We will deprecate the paver asset commands all at once once the new non-paver stuff is 100% working.
TODO: will copy in commit message from PR when squash merging Part of: openedx#32481
TODO: will copy in commit message from PR when squash-merging Part of: openedx#32481
kdmccormick
force-pushed
the
kdmccormick/compile-sass-py
branch
6 times, most recently
from
July 19, 2023 21:16
2e59065 to
411967e
Compare
TODO: will copy in commit message from PR when squash-merging Part of: openedx#31604
TODO update ADR TODO make compile-requirements TODO testing TODO: will copy in commit message from PR when squash-merging Part of: TODO
kdmccormick
force-pushed
the
kdmccormick/compile-sass-py
branch
from
July 20, 2023 13:49
d96cd70 to
b9b6a7f
Compare
Member
Author
|
closed in favor of #32823 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.