Skip to content

Revert "refactor: reuse services and wrappers between XBlocks" [FC-0026] - #32730

Merged
bszabo merged 1 commit into
openedx:masterfrom
open-craft:agrendalath/revert_fc-0026-cache_runtime_services_and_wrappers
Jul 13, 2023
Merged

Revert "refactor: reuse services and wrappers between XBlocks" [FC-0026]#32730
bszabo merged 1 commit into
openedx:masterfrom
open-craft:agrendalath/revert_fc-0026-cache_runtime_services_and_wrappers

Conversation

@Agrendalath

@Agrendalath Agrendalath commented Jul 13, 2023

Copy link
Copy Markdown
Member

This reverts commit 36cc415 from #32420.
I didn't add a revert for 6a8e695, as this is a trivial change.

The affected invocation of the PartitionService is here. The code that triggers the exception directly is here. Therefore, the course_id is missing here (or maybe the course_id is invalid, so modulestore().get_course(self._course_id) returns None).

Note: So far, we could not reproduce the reported behavior locally, and the available traceback does not clarify how the submitted issue is related to this commit.

@Agrendalath
Agrendalath requested a review from ormsbee July 13, 2023 11:44
@Agrendalath Agrendalath self-assigned this Jul 13, 2023
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core committer labels Jul 13, 2023
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @Agrendalath!

As a core committer in this repo, you can merge this once the pull request is approved per the core committer reviewer requirements and according to the agreement with your edX Champion.

@Agrendalath Agrendalath changed the title Revert "refactor: reuse services and wrappers between XBlocks" Revert "refactor: reuse services and wrappers between XBlocks" [FC-0026] Jul 13, 2023
@bszabo
bszabo merged commit c6bd98e into openedx:master Jul 13, 2023
@openedx-webhooks

Copy link
Copy Markdown

@Agrendalath 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@Agrendalath
Agrendalath deleted the agrendalath/revert_fc-0026-cache_runtime_services_and_wrappers branch July 13, 2023 15:23
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core committer open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants