revert: build: copy from node_modules using NPM postinstall hook, not Paver - #32766
Merged
Merged
Conversation
brian-smith-tcril
approved these changes
Jul 17, 2023
kdmccormick
enabled auto-merge (squash)
July 17, 2023 18:12
kdmccormick
disabled auto-merge
July 17, 2023 18:13
kdmccormick
enabled auto-merge (squash)
July 17, 2023 18:13
kdmccormick
disabled auto-merge
July 17, 2023 18:14
kdmccormick
enabled auto-merge
July 17, 2023 18:14
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #32717 since it is breaking the Docker build,
both in the edx-platform CI, and for Tutor Nightly.
The problems seems to be that
npm installis run beforescripts/is copied in, but the new post-install hook counts on
scripts/copy-node-modules.shexisting.