System defined taxonomies - #32869
Conversation
27f00b4 to
c88660f
Compare
There was a problem hiding this comment.
TODO: Update this when openedx/openedx-core#67 is deployed
There was a problem hiding this comment.
Once openedx/openedx-core#67 (comment) is done, could you update this to be:
openedx-learning<0.2
We'll do all our MVP changes under 0.1.x, and so this will mean they're picked up in the platform automatically.
Is that ok @bradenmacdonald , or do we need to bump the minor release every time too?
There was a problem hiding this comment.
@pomegranited Good idea, let's do that. Though on the platform side, I think you're not supposed to put any version constraints in this file at all, but rather in constraints.txt. So we can probably just leave it un-pinned for now? And keep in mind the platform dependencies only get updated once a week or so, so we'll likely need to do manual version bumps sometimes when we need to pull the newer version in sooner.
There was a problem hiding this comment.
@bradenmacdonald Ah cool, I'm happy with unpinned.
There was a problem hiding this comment.
@ChrisChV I've merged your openedx/openedx-core#67 and tagged it as v0.1.1.
So if you unpin openedx-learning and re-compile the requirements, it should pick up the latest version? You can use this comment (which is what I should have done when I added this requirement):
openedx-learning # Open edX Learning core (experimental)
c88660f to
d3cd671
Compare
bradenmacdonald
left a comment
There was a problem hiding this comment.
Mostly LGTM. @pomegranited if you can confirm that you've tested this, I'll approve and merge.
c1ae8b1 to
60c8e6f
Compare
…tem taxonomies Pulls the ContentTaxonomy-specific logic into a mixin class to bring the Content-specific logic into other Taxonony subclasses.
60c8e6f to
51f2fc5
Compare
Thanks @bradenmacdonald . I've re-tested this and it's working as expected, with one change (since the language taxonomy actually lives in And thank you @ChrisChV for ensuring the data migrations could be un-applied cleanly in case we need to roll back this change. It's good to merge once @ChrisChV gets a chance to update the requirements. |
|
Thanks @pomegranited 😄
Done 👍 It's ready to merge |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
Add the object tags for the system defined taxonomies that will be used in the platform. In addition, a migration has been created that loads the fixtures that create the System defined taxonomies
Testing instructions
masteropenedx/devstack up and running.paver install_prereqsin the LMS shell (from devstack dir, runmake lms-shell) and CMS shell (make studio-shell)../manage.py lms migratein the LMS shell../manage.py lms shell./manage.py lms migrate content_tagging 0001Deadline
None
Other information
Relates to openedx/modular-learning#77
Depends on openedx/openedx-core#67
Data migrations added here can be easily rolled back.