fix: include the correct SCSS file for lti_block - #33155
Merged
Merged
Conversation
lti_block has Sass for its display, but not for its editor.
During the `add_sass_to_fragment` refactoring, I mixed this up:
I added a non-existent scss file to the studio_view but didn't add
the actual scss file to the student_view.
Course authors using the (deprecated) lti_block saw:
We're having trouble rendering your component
Students will not be able to access this component. Re-edit your component to fix the error.
Error: Sass not found: /edx/app/edxapp/edx-platform/xmodule/assets/LTIBlockEditor.scss
as a result of this bug.
Original PR: openedx#32592
Private-ref: https://2u-internal.atlassian.net/browse/TNL-11029
kenclary
approved these changes
Sep 1, 2023
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing
I confirmed this fix using Tutor and an export of the course from the original (private) bug report. Here's how I tested.
Setup:
Bug reproduction (master)
Error: Sass not found: /edx/app/edxapp/edx-platform/xmodule/assets/LTIBlockEditor.scssLTIBlockDisplay.cssis NOT loaded.Bug fix confirmation (this branch):
LTIBlockDisplay.cssIS loaded.Description
lti_block has Sass for its display, but not for its editor.
During the
add_sass_to_fragmentrefactoring, I mixed this up: I added a non-existent scss file to the studio_view but didn't add the actual scss file to the student_view.Course authors using the (deprecated) lti_block saw:
as a result of this bug.
Original PR: #32592
Private-ref: https://2u-internal.atlassian.net/browse/TNL-11029