Skip to content

Move content_tagging django app so that CMS-only tests run - #33259

Merged
bradenmacdonald merged 9 commits into
openedx:masterfrom
open-craft:rpenido/fal-3500-move-content-tagging-django-app
Sep 21, 2023
Merged

Move content_tagging django app so that CMS-only tests run#33259
bradenmacdonald merged 9 commits into
openedx:masterfrom
open-craft:rpenido/fal-3500-move-content-tagging-django-app

Conversation

@rpenido

@rpenido rpenido commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

Description

This PR moves the content_tagging from openedx/features/ to openedx/core/djangoapps/content_tagging the tagging REST API for creating/updating object tags in Courses and XBlocks.

Supporting Information

Testing instructions

  • Ensure that the tests cover content_tagging in the openedx-4 shard.

Private ref: FAL-3500

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 14, 2023
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@rpenido
rpenido force-pushed the rpenido/fal-3500-move-content-tagging-django-app branch from 2974693 to f24910c Compare September 14, 2023 20:07

@ChrisChV ChrisChV left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpenido Looks good.

  • I read through the code
  • I ran the tests locally
  • I checked the test on the CI

@rpenido
rpenido force-pushed the rpenido/fal-3500-move-content-tagging-django-app branch from f8e691d to 5099629 Compare September 19, 2023 12:51
@rpenido

rpenido commented Sep 19, 2023

Copy link
Copy Markdown
Contributor Author

Hi @bradenmacdonald!

This is ready for your review!

@bradenmacdonald
bradenmacdonald merged commit e45460a into openedx:master Sep 21, 2023
@bradenmacdonald
bradenmacdonald deleted the rpenido/fal-3500-move-content-tagging-django-app branch September 21, 2023 19:01
@openedx-webhooks

Copy link
Copy Markdown

@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants