Simplify Tag Models [FC-0030] - #33378
Conversation
|
Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
9fa1477 to
dbbbed9
Compare
ChrisChV
left a comment
There was a problem hiding this comment.
@bradenmacdonald Looks good 👍
- I tested this runing the test.
- I read through the code.
- Includes documentation
350bc04 to
3fba862
Compare
Agrendalath
left a comment
There was a problem hiding this comment.
Nice cleanup 👍
- I tested this: checked that the CI is passing
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository: n/a
|
@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
This PR goes along with openedx/openedx-core#87 and makes some simplifications and clean ups to the "content tagging" app.
Interestingly, I didn't have to change the
viewsortest_viewsat all - those tests are all still passing with no changes.Note: it is now a bit safer to edit these models in the Django admin, because ObjectTag now has a
clean()method which performs some basic validation.Supporting information
Issue: openedx/modular-learning#85
Testing instructions
For now just run the test suite; this app doesn't have a UI yet.
Deadline
None
Private-ref: FAL-3477