[FC-0036] feat: Display Units Taxonomy Tags in drawer by yusuf-musleh · Pull Request #33563 · openedx/openedx-platform

yusuf-musleh · 2023-10-23T13:53:55Z

Description

This adds "Manage Tags" action in the units' dropdown that opens up a side drawer containing an iframe to the course authoring mfe that will handle the taxonomy tags UI for the unit.

Clicking outside the side drawer or on the x in the iframe closes the side drawer.

Supporting information

Related Tickets:

[Tagging] Display a unit's tags in the tag drawer modular-learning#118

Related PRs:

[FC-0036] feat: Add ContentTagsDrawer widget frontend-app-authoring#654

Testing instructions

Make sure you have the frontend-app-course-authoring repo cloned and checkout the branch of this PR [FC-0036] feat: Add ContentTagsDrawer widget frontend-app-authoring#654
Start the frontend-app-course-authoring with npm start
Checkout this PRs branch and run it in your devstack
If you don't already have sample taxonomy/tags data, follow the instructions in this repo to generate sample data: https://github.com/open-craft/taxonomy-sample-data
Navigate to studio to one of the sample course created in from the previous step: http://localhost:18010/course/course-v1:SampleTaxonomyOrg1+STC1+2023_1
Locate a unit in the course outline page, and confirm that the there is no tags button showing in either the actions dropdown or next to it
Next, navigate to http://localhost:18010/admin/waffle/flag/ and create a new flag: new_studio_mfe.use_tagging_taxonomy_list_page make sure it is active for everyone
Navigate back to the course outline page, refresh it, you should see the tags button with a question mark (the count will be implemented in a later PR), along with the "Manage Tags" option in the actions dropdown.

Confirm that both methods open the side drawer with no issues
Testing the drawer functionality is part of the testing instructions in the PR [FC-0036] feat: Add ContentTagsDrawer widget frontend-app-authoring#654

Private-ref: FAL-3523

openedx-webhooks · 2023-10-23T13:54:01Z

Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

open-craft-grove · 2023-11-01T16:34:23Z

Sandbox deployment started.

open-craft-grove · 2023-11-01T17:08:21Z

Sandbox deployment successful.

Sandbox LMS is available at pr-33563-139931.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-33563-139931.staging.do.opencraft.hosting

open-craft-grove · 2023-11-02T09:25:47Z

Sandbox deployment started.

open-craft-grove · 2023-11-02T09:53:37Z

Sandbox deployment successful.

Sandbox LMS is available at pr-33563-139931.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-33563-139931.staging.do.opencraft.hosting

open-craft-grove · 2023-11-02T11:48:28Z

Sandbox deployment started.

open-craft-grove · 2023-11-02T12:16:36Z

Sandbox deployment successful.

Sandbox LMS is available at pr-33563-139931.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-33563-139931.staging.do.opencraft.hosting

bradenmacdonald · 2023-11-07T18:45:56Z

@yusuf-musleh Is this PR ready for review, or are you thinking it might change still? When it's ready, can you please update the description and mark it as non-draft?

This adds "Manage Tags" action in the units' dropdown that opens up a side drawer containing an iframe to the course authoring mfe that will handle the taxonomy tags UI for the unit. Clicking outside the side drawer or on the x in the iframe closes the side drawer.

Using the same existing ENABLE_TAGGING_TAXONOMY_LIST_PAGE flag.

open-craft-grove · 2023-11-08T12:49:36Z

Sandbox deployment started.

yusuf-musleh · 2023-11-08T13:22:26Z

@yusuf-musleh Is this PR ready for review, or are you thinking it might change still? When it's ready, can you please update the description and mark it as non-draft?

@bradenmacdonald Just wrapped up the PR and its ready for your review!

open-craft-grove · 2023-11-08T13:24:50Z

Sandbox deployment successful.

Sandbox LMS is available at pr-33563-139931.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-33563-139931.staging.do.opencraft.hosting

bradenmacdonald

👍

I tested this: in Studio, with and without the feature flag
I read through the code
I checked for accessibility issues: yes, it's keyboard accessible
Includes documentation: n/a for now

openedx-webhooks · 2023-11-08T20:23:09Z

@yusuf-musleh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

open-craft-grove · 2023-11-08T20:45:36Z

Sandbox update request received. Deployment will start soon.

open-craft-grove · 2023-11-08T21:00:47Z

Sandbox update request received. Deployment will start soon.

edx-pipeline-bot · 2023-11-08T21:30:31Z

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

edx-pipeline-bot · 2023-11-08T21:48:57Z

2U Release Notice: This PR has been deployed to the edX production environment.

edx-pipeline-bot · 2023-11-08T21:48:57Z

2U Release Notice: This PR has been deployed to the edX production environment.

edx-pipeline-bot · 2023-11-08T22:08:29Z

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

edx-pipeline-bot · 2023-11-08T22:29:42Z

2U Release Notice: This PR has been deployed to the edX production environment.

…enedx#33563)

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 23, 2023

yusuf-musleh changed the title ~~feat: Display Units Taxonomy Tags in drawer~~ [WIP] feat: Display Units Taxonomy Tags in drawer Oct 23, 2023

yusuf-musleh force-pushed the yusuf-musleh/units-taxonomy-tags-drawer branch from 0af988f to e6e5b3d Compare October 24, 2023 10:52

yusuf-musleh changed the title ~~[WIP] feat: Display Units Taxonomy Tags in drawer~~ [WIP] [FC-0036] feat: Display Units Taxonomy Tags in drawer Oct 24, 2023

yusuf-musleh force-pushed the yusuf-musleh/units-taxonomy-tags-drawer branch from e6e5b3d to cda7147 Compare October 27, 2023 07:31

bradenmacdonald added the FC Relates to an Axim Funded Contribution project label Oct 30, 2023

yusuf-musleh force-pushed the yusuf-musleh/units-taxonomy-tags-drawer branch from cda7147 to 03546a8 Compare November 1, 2023 16:21

yusuf-musleh force-pushed the yusuf-musleh/units-taxonomy-tags-drawer branch from 03546a8 to e1f9757 Compare November 2, 2023 08:24

bradenmacdonald mentioned this pull request Nov 2, 2023

Update openedx-learning, new format for the "get object tags" REST API (unstable) [FC-0036] #33651

Merged

yusuf-musleh force-pushed the yusuf-musleh/units-taxonomy-tags-drawer branch from 4494e90 to 9773d55 Compare November 3, 2023 07:53

bradenmacdonald reviewed Nov 3, 2023

View reviewed changes

Comment thread cms/static/js/views/course_outline.js Outdated

yusuf-musleh force-pushed the yusuf-musleh/units-taxonomy-tags-drawer branch from 9773d55 to c4e1562 Compare November 5, 2023 11:07

yusuf-musleh added 4 commits November 8, 2023 11:11

feat: Place manage tags behind waffle flag

2da7168

Using the same existing ENABLE_TAGGING_TAXONOMY_LIST_PAGE flag.

test: Update failing test case

b3be8ab

feat: Auto focus on iframe when opened

8518acb

yusuf-musleh force-pushed the yusuf-musleh/units-taxonomy-tags-drawer branch from 82be057 to 8518acb Compare November 8, 2023 12:37

yusuf-musleh marked this pull request as ready for review November 8, 2023 13:00

yusuf-musleh changed the title ~~[WIP] [FC-0036] feat: Display Units Taxonomy Tags in drawer~~ [FC-0036] feat: Display Units Taxonomy Tags in drawer Nov 8, 2023

yusuf-musleh mentioned this pull request Nov 8, 2023

[FC-0036] feat: Add ContentTagsDrawer widget openedx/frontend-app-authoring#654

Merged

bradenmacdonald approved these changes Nov 8, 2023

View reviewed changes

bradenmacdonald merged commit e311ef5 into openedx:master Nov 8, 2023

bradenmacdonald deleted the yusuf-musleh/units-taxonomy-tags-drawer branch November 8, 2023 20:23

bradenmacdonald mentioned this pull request Nov 9, 2023

Minor fixes for tagging django admin [FC-0036] openedx/openedx-core#114

Merged

andrey-canon mentioned this pull request May 7, 2024

feat: Studio menu/button to display Unit's Tags (feature flagged) (#3… nelc/edx-platform#24

Merged

andrey-canon pushed a commit to nelc/edx-platform that referenced this pull request May 15, 2024

feat: Studio menu/button to display Unit's Tags (feature flagged) (op…

a5d7a37

…enedx#33563)

Uh oh!

Conversation

yusuf-musleh commented Oct 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Supporting information

Testing instructions

Uh oh!

openedx-webhooks commented Oct 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

open-craft-grove commented Nov 1, 2023

Uh oh!

open-craft-grove commented Nov 1, 2023

Uh oh!

open-craft-grove commented Nov 2, 2023

Uh oh!

open-craft-grove commented Nov 2, 2023

Uh oh!

open-craft-grove commented Nov 2, 2023

Uh oh!

open-craft-grove commented Nov 2, 2023

Uh oh!

Uh oh!

bradenmacdonald commented Nov 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

open-craft-grove commented Nov 8, 2023

Uh oh!

yusuf-musleh commented Nov 8, 2023

Uh oh!

open-craft-grove commented Nov 8, 2023

Uh oh!

bradenmacdonald left a comment

Choose a reason for hiding this comment

Uh oh!

openedx-webhooks commented Nov 8, 2023

Uh oh!

open-craft-grove commented Nov 8, 2023

Uh oh!

open-craft-grove commented Nov 8, 2023

Uh oh!

edx-pipeline-bot commented Nov 8, 2023

Uh oh!

edx-pipeline-bot commented Nov 8, 2023

Uh oh!

edx-pipeline-bot commented Nov 8, 2023

Uh oh!

edx-pipeline-bot commented Nov 8, 2023

Uh oh!

edx-pipeline-bot commented Nov 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

yusuf-musleh commented Oct 23, 2023 •

edited

Loading

openedx-webhooks commented Oct 23, 2023 •

edited

Loading

bradenmacdonald commented Nov 7, 2023 •

edited

Loading