feat: Add tags count for v2 library components - #33979
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
32c6980 to
3efde87
Compare
rpenido
left a comment
rpenido
left a comment
There was a problem hiding this comment.
LGTM 👍
- I tested this following the instructions from openedx-unsupported/frontend-app-library-authoring#400
- I read through the code
-
I checked for accessibility issues - Includes documentation
Only a nit while replacing lib:
3efde87 to
9766937
Compare
49c6fa5 to
3dc1047
Compare
|
@bradenmacdonald This is ready for CC review. |
bradenmacdonald
left a comment
bradenmacdonald
left a comment
There was a problem hiding this comment.
Looks good to me. Just need to wait for that version bump and then we can merge this.
There was a problem hiding this comment.
Don't you mean count_implicit=True ?
I opened a version bump PR here: openedx/openedx-core#140
There was a problem hiding this comment.
Yup, I've update the PR with the new openedx-learning version and added the count_implicit=True to it, working as expected now.
3dc1047 to
89a8be9
Compare
|
@yusuf-musleh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
5 participants
Description
Includes content tags counts (including implicit) for Library V2 components in their metadata response.
Supporting information
Related Tickets:
Testing instructions
Follow the testing instructions on openedx-unsupported/frontend-app-library-authoring#400, specifically make sure the tags counts appear correctly.
Private-ref: FAL-3599