refactor: Update tags drawer listener for a Json message - #34223
refactor: Update tags drawer listener for a Json message#34223ChrisChV wants to merge 2 commits into
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
| var courseAuthoringUrl = this.model.get("course_authoring_url") | ||
| if (event.origin == courseAuthoringUrl | ||
| && data.includes('[Manage tags drawer] Count updated:')) { | ||
| && data.type == 'authoring.events.tags.count.updated') { |
There was a problem hiding this comment.
This is not working for me in tutor. event.origin is "http://apps.local.overhang.io:2001" while courseAuthoringUrl is "http://apps.local.overhang.io:2001/course-authoring".
There was a problem hiding this comment.
Changing this to var courseAuthoringUrl = new URL(this.model.get("course_authoring_url")).origin; worked.
mphilbrick211
added
the
waiting for eng review
|
Closing this for now as we're focusing on the MFE which doesn't need this message system. |
|
@ChrisChV Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
5 participants
Description
Blocked: Check this openedx/frontend-app-authoring#800 (comment)
The drawer tag listener code has been changed to accept messages in JSON structure.
This is a small refactor of the code in response to this comment: openedx/frontend-app-authoring#800 (review)
Supporting information
Internal ticket: FAL-3601
Github issue: openedx/modular-learning#167
Related PRs:
Testing instructions
Follow the testing instructions of #34059