refactor: update to use Learning Core's new public API - #34815
Merged
Conversation
ormsbee
marked this pull request as draft
May 17, 2024 04:17
ormsbee
force-pushed
the
learning-core-api-refactor
branch
2 times, most recently
from
May 21, 2024 18:55
d18f1b8 to
693849b
Compare
ormsbee
marked this pull request as ready for review
May 21, 2024 18:55
kdmccormick
approved these changes
May 21, 2024
This also bumps our openedx-learning dependency to 0.10.0 (the first version with the new openedx_learning.api package).
ormsbee
force-pushed
the
learning-core-api-refactor
branch
from
May 21, 2024 19:15
693849b to
e7402fc
Compare
Contributor
|
Nice! |
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on openedx/openedx-core#184
This is a disruptive, backwards-incompatible change as far as code is concerned, but involves no database changes.
openedx_learning.api.authoringinstead of individual apps.openedx_learning.api.authoring_models.openedx_learning.appsis intended to be private.