Skip to content

feat: add collections app from openedx-learning [FC-0059] - #35312

Merged
pomegranited merged 1 commit into
openedx:masterfrom
open-craft:rpenido/fal-3782-add-collections-app-from-openedx-learning
Aug 23, 2024
Merged

feat: add collections app from openedx-learning [FC-0059]#35312
pomegranited merged 1 commit into
openedx:masterfrom
open-craft:rpenido/fal-3782-add-collections-app-from-openedx-learning

Conversation

@rpenido

@rpenido rpenido commented Aug 14, 2024

Copy link
Copy Markdown
Contributor

Description

This PR updates the openedx-learning package, adding the oel_colections app

More information


Private ref: FAL-3782

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 14, 2024
@openedx-webhooks

openedx-webhooks commented Aug 14, 2024

Copy link
Copy Markdown

Thanks for the pull request, @rpenido!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@rpenido
rpenido force-pushed the rpenido/fal-3782-add-collections-app-from-openedx-learning branch from 12df826 to 2a6f0f2 Compare August 14, 2024 14:12
@rpenido rpenido changed the title feat: add collections app from openedx-learning feat: add collections app from openedx-learning [FC-0059] Aug 15, 2024
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Aug 15, 2024
@rpenido
rpenido force-pushed the rpenido/fal-3782-add-collections-app-from-openedx-learning branch 2 times, most recently from 4d2b867 to b556a5b Compare August 22, 2024 13:53
@rpenido
rpenido marked this pull request as ready for review August 22, 2024 14:06
@rpenido
rpenido force-pushed the rpenido/fal-3782-add-collections-app-from-openedx-learning branch from b556a5b to e879244 Compare August 22, 2024 14:08
@rpenido
rpenido requested a review from pomegranited August 22, 2024 14:32

@pomegranited pomegranited left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this by running this branch in my devstack and openedx-learning==0.11.1 installed in the virtualenv. Using the shell, I tested that I can use the collections API:

    from openedx_learning.api.authoring import create_collection
    collection = create_collection(1, title="Collection A", created_by=None, description="First collection")
    collection.title
    # output: 'Collection A'
    
  • I read through the code

  • I checked for accessibility issues N/A

  • Includes documentation N/A

  • User-facing strings are extracted for translation N/A

@pomegranited
pomegranited merged commit 5fbcc79 into openedx:master Aug 23, 2024
@openedx-webhooks

Copy link
Copy Markdown

@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

rediris pushed a commit to gymnasium/edx-platform that referenced this pull request Aug 27, 2024
@rpenido
rpenido deleted the rpenido/fal-3782-add-collections-app-from-openedx-learning branch August 29, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants