feat: itembank green button - #35706
Conversation
|
Thanks for the pull request, @DanielVZ96! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
@kdmccormick did you try running |
| # Libraries v2 content doesn't have an XBlock. | ||
| if category == 'library_v2': | ||
| if category in ('library_v2', 'itembank'): | ||
| return None |
There was a problem hiding this comment.
I'm assuming this is the case for itembank too
There was a problem hiding this comment.
@DanielVZ96 unlike library_v2, itembank is actually a real XBlock tag (the class is ItemBankBlock), so it'd be fine to let this function return the mixed class.
(The only thing that this function's return value is used for is templates, which ItemBankBlock doesn't currently use, so you're change here technically isn't breaking anything. Still, I'd rather you revert this line so that we can minimize the number of special cases.)
|
The new itembank icon png is currently larger (256x256 pixels) than the other green button icon pngs, which might be why it doesn't fit. Here's it shrunk down to 38x38, which I think looks alright: If you apply this and address #35706 (comment), then I'll be happy to approve & merge this in the morning tomorrow. |
(itembank is a real XBlock)
pomegranited
left a comment
There was a problem hiding this comment.
👍 Looks great, thank you @DanielVZ96 !
Note: The problem blank XBlock added by this new button needs #35705 to function properly, but the button looks and works as needed.
- I tested this using the PR test instructions
- I read through the code
- I checked for accessibility issues by using my keyboard to navigate
-
Includes documentationN/A - User-facing strings are extracted for translation
|
I believe I've addressed your comments @kdmccormick -- let me know if there's anything else that needs fixing? |
kdmccormick
left a comment
There was a problem hiding this comment.
Looks great, thank you both!
I'll merge this one right after the ItemBank UI PR.
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |




Description
Adds Problem Bank to the main New Components buttons.
Supporting information
Testing instructions
tutor dev exec cms npm run watchto build scss changesDeadline
ASAP