Dropping Sass support from builtin annotatable block - #35716
Merged
Conversation
…g with vanilla CSS
farhan
force-pushed
the
farhan/sass-to-css-annotatable-block-2
branch
from
October 24, 2024 10:46
d6d57ff to
b3f2f93
Compare
farhan
marked this pull request as ready for review
October 24, 2024 14:01
irtazaakram
approved these changes
Oct 28, 2024
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropping Sass support from builtin annotatable block
Tickets: #35570
Tasks:
Convert Sass variable into css variables
Compile the css file of the block following given steps.
xmodule/static/css-builtin-blocks.Replace add_sass_to_fragment to add_css_to_fragment in blocks
.pyfileRemove all .scss files linked to the block under xmodule/assets.
Testing Notes:
npm run buildto run webpack and compile sass files../manage.py lms collectstaticin lms shell to re-collect static files../manage.py cms collectstaticin cms shell to re-collect static files.Reference PR:
Here is initial reference PR [Some the changes are only 1 time changes so don't need them in next block PR's.]