feat!: Remove the course sock and related APIs. - #36436
Merged
Merged
Conversation
feanil
changed the title
feanil
added a commit
to openedx/frontend-app-learning
that referenced
this pull request
Mar 24, 2025
DEPR: openedx/openedx-platform#36429 This piece of data is not being used anywhere but was still being consumed so just drop the data so that the backend can be updated to no longer provide the data. The backend API is being updated in openedx/openedx-platform#36436
feanil
force-pushed
the
feanil/update_courseware_links
branch
from
March 24, 2025 17:14
b7162ec to
c0324e8
Compare
feanil
force-pushed
the
feanil/remove_courseware_sock
branch
3 times, most recently
from
March 24, 2025 17:48
1a9c325 to
1a514a2
Compare
feanil
force-pushed
the
feanil/update_courseware_links
branch
from
March 24, 2025 18:09
c0324e8 to
e1a3a6b
Compare
feanil
force-pushed
the
feanil/remove_courseware_sock
branch
from
March 24, 2025 18:14
1a514a2 to
32bd1ab
Compare
feanil
marked this pull request as ready for review
March 31, 2025 16:41
feanil
force-pushed
the
feanil/update_courseware_links
branch
from
April 4, 2025 18:01
e1a3a6b to
cdf2603
Compare
DEPR: #36429 This change removes the course_sock and related API data. The UI it removes is on the Legacy Courseware pages which have also been replaced and have their own [deprecation ticket](#35803) Before this can be merged, we will need to update the frontend-app-learning MFE to no longer consume the `can_show_upgrade_sock` attribute. BREAKING CHANGE: CourseHomeMetadata, ProgressTab, OutlineTab and VerifiedMode APIs will no longer have a `can_show_upgrade_sock` attribute.
feanil
force-pushed
the
feanil/remove_courseware_sock
branch
from
April 7, 2025 14:29
32bd1ab to
1829eb7
Compare
bradenmacdonald
approved these changes
Apr 8, 2025
bradenmacdonald
left a comment
bradenmacdonald
left a comment
Contributor
There was a problem hiding this comment.
I don't know whether or not 2U is still using this, but otherwise the removal looks good to me. Thanks for cleaning this up!
kdmccormick
removed their request for review
April 9, 2025 13:58
feanil
added a commit
to openedx/frontend-app-learning
that referenced
this pull request
Apr 9, 2025
DEPR: openedx/openedx-platform#36429 This piece of data is not being used anywhere but was still being consumed so just drop the data so that the backend can be updated to no longer provide the data. The backend API is being updated in openedx/openedx-platform#36436
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
nsprenkle
pushed a commit
to edx/frontend-app-learning
that referenced
this pull request
Apr 28, 2025
DEPR: openedx/openedx-platform#36429 This piece of data is not being used anywhere but was still being consumed so just drop the data so that the backend can be updated to no longer provide the data. The backend API is being updated in openedx/openedx-platform#36436
jciasenza
pushed a commit
to jciasenza/frontend-app-learning
that referenced
this pull request
May 19, 2025
DEPR: openedx/openedx-platform#36429 This piece of data is not being used anywhere but was still being consumed so just drop the data so that the backend can be updated to no longer provide the data. The backend API is being updated in openedx/openedx-platform#36436
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEPR: #36429
This change removes the course_sock and related API data. The UI it
removes is on the Legacy Courseware pages which have also been replaced
and have their own deprecation ticket
Before this can be merged, we will need to update the
frontend-app-learning MFE to no longer consume the
can_show_upgrade_sockattribute.BREAKING CHANGE: CourseHomeMetadata, ProgressTab, OutlineTab and
VerifiedMode APIs will no longer have a
can_show_upgrade_sockattribute.
This PR depends on #36430 and openedx/frontend-app-learning#1647 which need to merge first.