fix: Delete index when delete container & Restore container API added [FC-0083] - #36464
Conversation
|
Thanks for the pull request, @ChrisChV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
pomegranited
left a comment
There was a problem hiding this comment.
👍 Couple of nits and one suggestion -- but this is working well :)
- I tested this while testing openedx/frontend-app-authoring#1773
- I read through the code
-
I checked for accessibility issuesN/A - Updates documentation -- code comments, function docs
-
User-facing strings are extracted for translationN/A
|
|
||
|
|
||
| def delete_index_doc(usage_key: UsageKey) -> None: | ||
| def delete_index_doc(key: OpaqueKey) -> None: |
There was a problem hiding this comment.
Thank you for fixing these "usage key" references!
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
Supporting information
Testing instructions
Deadline
ASAP
Other information
N/A