docs: Update this super old readme - #36865
Conversation
|
I guess it would be too difficult to move |
It's doable with some effort, I've done similarly big moves of directories before (e.g. common/lib/xmodule/xmodule to xmodule), but the question would be-- why? So edx-platform can have one code root? I think that would be nice for our tooling, but I see it as less important than keeping some architectural boundaries between cms and lms. So I think this is the right update for now, and I'm open to considering directory moves in the future, especially if someone is willing to contribute the refactoring. |
100% Somewhere in my long-term-backlog is writing up a plan to move a ton of apps around so that edx-platform makes more sense. The challenging part is tha many edx-platform plugins import the code directly-- which is bad, and shouldn't be done in new plugins, but so many old plugins do it. Two options are:
|
This directory was created as part of an idea to create top-level openedx namespace which every Open edX package would nest itself under. The README was written with that in mind. That never panned out, so openedx is really just another "common" directory. Non-common code should not be added to it. This update clarifies that.
603cb12 to
2c67317
Compare
|
@kdmccormick Sounds good. At least for the few newer apps like the ones listed here, both plugins and edx-platform code should only have been importing from the |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
This directory was created as part of an idea [1] to create top-level openedx namespace which every Open edX package would nest itself under. The README was written with that in mind. That never panned out, so openedx is really just another "common" directory. Non-common code should not be added to it. This update clarifies that. [1] #5942 (comment)
This directory was created as part of an idea [1]
to create top-level openedx namespace which
every Open edX package, including those in other
repos, would nest itself under. The README
was written with that in mind.
That never panned out, so openedx is really just
another "common" directory. Non-common code
should not be added to it. This update clarifies that.
[1] #5942 (comment)