-
Notifications
You must be signed in to change notification settings - Fork 4.3k
[DRAFT] Unit Prerequisites Lost During Course Export/Import #37095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,13 +12,13 @@ | |
| from xblock.runtime import KvsFieldData | ||
| from xmodule.modulestore import EdxJSONEncoder | ||
| from xmodule.modulestore.inheritance import InheritanceKeyValueStore, own_metadata | ||
|
|
||
| log = logging.getLogger(__name__) | ||
|
|
||
| # assume all XML files are persisted as utf-8. | ||
| EDX_XML_PARSER = XMLParser(dtd_validation=False, load_dtd=False, remove_blank_text=True, encoding='utf-8') | ||
|
|
||
|
|
||
|
|
||
| def name_to_pathname(name): | ||
| """ | ||
| Convert a location name for use in a path: replace ':' with '/'. | ||
|
|
@@ -455,6 +455,28 @@ def add_xml_to_node(self, node): | |
| xml_object.tag = self.category | ||
| node.tag = self.category | ||
|
|
||
| # Populate Prerequisite information of a sequential object | ||
| if self.category == 'sequential': | ||
| course_id = self.scope_ids.usage_id.context_key | ||
| content_id = self.location | ||
| logging.warning(f'INSPECTING-LOG self type is = %s', type(self)) | ||
| logging.warning(f'INSPECTING-LOG self vars is = %s', vars(self)) | ||
|
|
||
| logging.warning(f'INSPECTING-LOG course_id is = %s', course_id) | ||
| logging.warning(f'INSPECTING-LOG content_id is = %s', content_id) | ||
|
|
||
| milestone = self.get_prereq_metadata(course_id, content_id) | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The values to be exported will be populated from the results found at milestone object. @Cup0fCoffee |
||
| if milestone : | ||
| logging.warning(f'INSPECTING-LOG milestone type is = %s', type(milestone)) | ||
| logging.warning(f'INSPECTING-LOG milestone vars is = %s', vars(milestone)) | ||
| # xml_object.set('is_prereq', '') | ||
| # xml_object.set('prereq', '') | ||
| # xml_object.set('prereq_min_score', '') | ||
| # xml_object.set('prereq_min_completion', '') | ||
| else : | ||
| logging.warning(f'INSPECTING-LOG milestone is None= %s', (milestone)) | ||
|
|
||
|
|
||
| # Add the non-inherited metadata | ||
| for attr in sorted(own_metadata(self)): | ||
| # don't want e.g. data_dir | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Cup0fCoffee This always returns an empty object.