Skip to content

fix: reindex_studio could crash if an XBlock child isn't loadable #37177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bradenmacdonald merged 2 commits into from
Oct 3, 2025
Merged

fix: reindex_studio could crash if an XBlock child isn't loadable #37177

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37830c1
fix: reindex_studio could crash if an XBlock child isn't loadable
bradenmacdonald Aug 11, 2025
9b929e2
Merge branch 'master' into braden/fix-index-issue
ChrisChV Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions openedx/core/djangoapps/content/search/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
from openedx.core.djangoapps.content.search.models import IncrementalIndexCompleted, get_access_ids_for_request
from openedx.core.djangoapps.content_libraries import api as lib_api
from xmodule.modulestore.django import modulestore
from xmodule.modulestore.exceptions import ItemNotFoundError

from .documents import (
Fields,
Expand Down Expand Up @@ -278,6 +279,9 @@ def _recurse_children(block, fn, status_cb: Callable[[str], None] | None = None)
for child_id in block.children:
try:
child = block.get_child(child_id)
if child is None:
# XBlocks with XModuleMixin will return None from get_child() instead of raising an exception :/
raise ItemNotFoundError(f"block.get_child() from {block.usage_key} failed to load child {child_id}")
except Exception as err: # pylint: disable=broad-except
log.exception(err)
if status_cb is not None:
Expand Down
Loading