Fix/cdodge/update localdev setting for unsafe courses - #372
Merged
chrisndodge merged 3 commits intoJul 11, 2013
Conversation
added 2 commits
July 11, 2013 12:05
…mon.py, although cms.envs.common.py imports lms.envs.common (where this is defined).
…aults to an empty set
Contributor
|
This line doesn't pull in everything from lms: It just makes that available for this later: Here's how we copied a value from lms to cms: |
Contributor
|
Good to merge. 👍 |
Contributor
Author
|
@cahrens can I get a thumbs up from you? UPDATE: I added the unit test I know you were going to ask for :-) |
|
👍 |
chrisndodge
pushed a commit
that referenced
this pull request
Jul 11, 2013
…or-unsafe-courses Fix/cdodge/update localdev setting for unsafe courses
chrisndodge
deleted the
fix/cdodge/update-localdev-setting-for-unsafe-courses
branch
August 8, 2013 18:39
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
New external grader format: JSON-serialized dict
Kelketek
referenced
this pull request
in open-craft/openedx-platform
Jan 21, 2015
fixed issues with organization metrics when organization has multiple courses
hachiyanagi-ks
added a commit
to nttks/edx-platform
that referenced
this pull request
Oct 2, 2015
…x-messages-dashboard Fix messages for dashboard openedx#314
hachiyanagi-ks
added a commit
to nttks/edx-platform
that referenced
this pull request
Oct 6, 2015
…x-messages-dashboard Fix messages for dashboard openedx#314 (cherry picked from commit 16852b7) Conflicts: conf/locale/ja_JP/LC_MESSAGES/django.po conf/locale/ja_JP/LC_MESSAGES/mako.po
diegomillan
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Sep 14, 2016
…o-help-urls Edit link to edX Studio Documentation
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
kiram15
pushed a commit
that referenced
this pull request
Jul 17, 2026
fix: honor YAML SEARCH_ENGINE override in production settings for LMS and CMS for meilisearch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure I know why - maybe @cpennington or @ormsbee might have an idea - but the "COURSES_WITH_UNSAFE_CODE" was not getting into the localdev CMS settings (dev.py), even though cms.envs.common.py imports lms.envs.common.py.
So added an explicit setting in cms.common.py as well as adding a highly restrictive default value.
@nedbat @cahrens can you review?