fix: prevent null start date in course details - #37299
Conversation
|
Thanks for the pull request, @viadanna! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
kaustavb12
left a comment
There was a problem hiding this comment.
👍
- I tested this: Tested the internal PR and verified that the exact same changes were carried over.
- I read through the code
- I checked for accessibility issues
- Includes documentation
|
|
||
| # Prevent setting release date to null | ||
| # remove field and inherit from parent instead | ||
| if metadata_key == "start" and value == "": |
There was a problem hiding this comment.
@viadanna I'm concerned about how generic this is. If other blocks have a "start" field, this behavior will also effect them right? Is that intended?
I think having this kind of logic that is specific to the course_details live in the course_details api makes more sense: https://github.com/openedx/edx-platform/blob/master/cms/djangoapps/contentstore/rest_api/v1/views/course_details.py#L121
But perhaps I'm missing something.
Description
This PR ensures a course cannot have an empty release date.
Ref: BB-9629
Testing instructions
Deadline
None