Skip to content

fix: prevent null start date in course details - #37299

Closed
viadanna wants to merge 2 commits into
openedx:masterfrom
open-craft:viadanna/null-release-master
Closed

fix: prevent null start date in course details#37299
viadanna wants to merge 2 commits into
openedx:masterfrom
open-craft:viadanna/null-release-master

Conversation

@viadanna

@viadanna viadanna commented Aug 28, 2025

Copy link
Copy Markdown
Contributor

Description

This PR ensures a course cannot have an empty release date.

Ref: BB-9629

Testing instructions

  1. Open Studio, navigate to a course, and set its release date to an empty string.
  2. Ensure it isn't changed.

Deadline

None

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 28, 2025
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @viadanna!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Aug 28, 2025
@viadanna viadanna self-assigned this Aug 28, 2025
@viadanna
viadanna requested a review from kaustavb12 August 28, 2025 11:12

@kaustavb12 kaustavb12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: Tested the internal PR and verified that the exact same changes were carried over.
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation


# Prevent setting release date to null
# remove field and inherit from parent instead
if metadata_key == "start" and value == "":

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viadanna I'm concerned about how generic this is. If other blocks have a "start" field, this behavior will also effect them right? Is that intended?

I think having this kind of logic that is specific to the course_details live in the course_details api makes more sense: https://github.com/openedx/edx-platform/blob/master/cms/djangoapps/contentstore/rest_api/v1/views/course_details.py#L121

But perhaps I'm missing something.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feanil If this is too generic, we can close the PR. The original intent was to fix an issue here, which was fixed in Teak by catching the AttributeError.

@viadanna viadanna closed this Nov 21, 2025
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Contributions Nov 21, 2025
@openedx-webhooks openedx-webhooks removed the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants