feat!: Upgrading to django52. - #37364
Conversation
awais786
added
the
create-sandbox
| # python3-openid | ||
| # social-auth-core | ||
| django==4.2.24 | ||
| django==5.2.6 |
There was a problem hiding this comment.
Version upgraded. Now this is pinned version.
|
Sandbox deployment failed 💥 |
|
Sandbox deployment failed 💥 |
Removed Django version '5.2' from the workflow.
|
Sandbox deployment failed 💥 |
|
Sandbox deployment failed 💥 |
|
|
||
| # Date: 2024-02-02 | ||
| # Stay on LTS version, remove once this is added to common constraint | ||
| Django<5.0 |
There was a problem hiding this comment.
Should this be updated to Django<6.0 rather than being removed?
There was a problem hiding this comment.
Updated the constraint to Django<6.0 instead.
|
Sandbox deployment failed 💥 |
|
Sandbox deployment failed 💥 |
|
Sandbox deployment failed 💥 |
|
Sandbox deployment failed 💥 |
|
@robrap could you help us create a 2U sandbox to test this PR? |
|
Sandbox deployment failed 💥 |
|
Is the OpenCraft sandbox not working? We have a pipeline/sandbox issue at this time. |
Above logs show the open craft sandbox failing but the error logs not show any error in it. |
|
It feels like the sandbox build can be flaky. The message has the following instructions:
Maybe it will build fine after a second try? |
|
Looks like the issue is with Tutor: https://openedx.slack.com/archives/C05519HHZKM/p1759846814275579?thread_ts=1759845987.738659&cid=C05519HHZKM So I think it's fine to merge this and that can be fixed upstream. |
|
Confirmed, this is upstreame here: https://github.com/overhangio/tutor/blob/release/tutor/templates/apps/openedx/settings/partials/common_all.py#L155-L161 |
|
@UsamaSadiq: Our pipeline and sandbox builds are still broken. Hopefully that will be resolved in the next day or so, if you would still like a 2U sandbox as well. |
|
@feanil @UsamaSadiq: Also, I assume all plugins need to be Django 5.2 compatible by the time this is merged, because edx-platform is what will define the Django version. Is that correct? I don't think we have a breaking change ticket and date filed, so maybe we can just handle this post-Ulmo? |
robrap
changed the title
django52.django52.
|
That's already done, all python libraries in the |
|
Filed a fix upstream: overhangio/tutor#1282 |
|
[inform] I added |
|
@robrap I don't think that's correct here, I was about to merge this. It's been well communicated: openedx/public-engineering#339 All libraries have been updated and testing is passing. |
feanil
changed the title
django52.django52.
|
Sandbox deployment failed 💥 |
|
@feanil: Here are some thoughts:
Given all of this, can you hold back for a moment so I can discuss with my team and figure out a game plan? |
|
Sure, how long do you need? |
|
@feanil: I'll get back to you in an hour. I presume you are going to merge (soon) and we are just going to have to find a way to deal with it on our end, but this will give me a moment to consider possibilities. Thank you. |
|
Happy to wait if you have specific things you want to check and a timeline to check them on. I was less okay with a general do-not-merge with no plan for who would be responsible for following up on that. Especially since, operators should be fully aware that this was coming and we've had plenty of places where folks can follow progress. Let me know how much time you need and when you expect to have more info. |
|
Sandbox deployment failed 💥 |
|
Sandbox deployment failed 💥 |
|
@feanil: Thanks for your patience. You are clear for take off. |
6 participants
Pre-merge Checklist
migratecommand to make sure no hidden migrations appear.NOTE:
Previously,
edx-platformwas usually the last service to upgrade to Django 5.2, which meant most issues were already discovered and resolved elsewhere. This time, however, it is the first service moving to Django 5.2, so we may need to wait for credential and discovery updates before proceeding.