feat!: Drop the legacy course_outline page. - #37462
Merged
Merged
Conversation
feanil
force-pushed
the
feanil/remove_accessibility_html
branch
from
October 10, 2025 19:38
1f148dd to
6816ba5
Compare
feanil
changed the base branch from
feanil/remove_accessibility_html
to
feanil/drop_course_home
October 10, 2025 19:39
feanil
force-pushed
the
feanil/drop_course_outline
branch
2 times, most recently
from
October 10, 2025 19:41
6086205 to
c863072
Compare
feanil
force-pushed
the
feanil/drop_course_home
branch
from
October 14, 2025 20:29
37dfbc4 to
7057510
Compare
feanil
force-pushed
the
feanil/drop_course_outline
branch
from
October 14, 2025 20:29
c863072 to
7459727
Compare
52 tasks
feanil
marked this pull request as ready for review
October 14, 2025 21:13
feanil
force-pushed
the
feanil/drop_course_home
branch
2 times, most recently
from
October 16, 2025 19:04
ade2299 to
4375bf5
Compare
feanil
force-pushed
the
feanil/drop_course_outline
branch
from
October 16, 2025 19:05
7459727 to
1a53f68
Compare
feanil
commented
Oct 17, 2025
| """ | ||
| course_key = self.get_course_key() | ||
| return toggles.use_new_course_outline_page(course_key) | ||
| return True |
Contributor
Author
There was a problem hiding this comment.
This API will get cleaned up as a part of #37497
Member
There was a problem hiding this comment.
here, and generally speaking, can you put the ticket link in the code?
feanil
force-pushed
the
feanil/drop_course_home
branch
from
October 17, 2025 14:25
4375bf5 to
7c8020d
Compare
feanil
force-pushed
the
feanil/drop_course_outline
branch
from
October 17, 2025 14:25
1a53f68 to
8e5df6c
Compare
kdmccormick
approved these changes
Oct 17, 2025
This page has been replaced with an equivalent page in the authoring MFE which has been on by default since Teak. This change removes the ability to fallback to the old page using waffle flags. BREAKING CHANGE: The `legacy_studio.course_outline` waffle flag will be removed and the code will behave as if it's always set to `False`. Preventing you from falling back to the old Course Outline page.
The tests were testing a set of menu items that were specifically available on the old course_outline page. Since the page is never rendered we don't need to test to see if those header items are actually rendered. As we finish the rest of the studio frontend cleanup, the header itself should be removed but just removing these tests since they relied on conditional bits of the header for when it was showing a course outline.
The removed tests either needed to check things on the outline page which makes them not relevant tests, or they just needed data from the course_handler which they can get from json now.
Co-authored-by: Kyle McCormick <kyle@axim.org>
feanil
force-pushed
the
feanil/drop_course_outline
branch
from
October 20, 2025 14:27
d9680d2 to
83cfa1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #36108
This page has been replaced with an equivalent page in the authoring MFE
which has been on by default since Teak. This change removes the
ability to fallback to the old page using waffle flags.
BREAKING CHANGE: The
legacy_studio.course_outlinewaffle flag will be removedand the code will behave as if it's always set to
False. Preventingyou from falling back to the old Course Outline page.
This drops the course outline page which also drops the course_status component coming from studio-frontend which is part of the work needed before we can drop studio-frontend.