Skip to content

build: Don't install @edx/studio-frontend - #37484

Merged
feanil merged 2 commits into
masterfrom
feanil/drop_studio_frontend_dependency
Oct 20, 2025
Merged

build: Don't install @edx/studio-frontend#37484
feanil merged 2 commits into
masterfrom
feanil/drop_studio_frontend_dependency

Conversation

@feanil

@feanil feanil commented Oct 14, 2025

Copy link
Copy Markdown
Contributor

The dependencies on this package via studio should all be removed now
and so we no longer need to install this package to pickup any
components from it.

This work is part of:

@feanil feanil added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Oct 14, 2025
@open-craft-grove

Copy link
Copy Markdown

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@feanil feanil removed the create-sandbox open-craft-grove should create a sandbox environment from this PR label Oct 15, 2025
@feanil

feanil commented Oct 15, 2025

Copy link
Copy Markdown
Contributor Author

There is still one component in the old unit editor that uses a component from studio-frontend, so we can't move forward with this one until #35261 is done.

@feanil
feanil force-pushed the feanil/drop_assets_and_files branch from 2e5e575 to da37eaa Compare October 16, 2025 19:07
@feanil
feanil force-pushed the feanil/drop_studio_frontend_dependency branch 2 times, most recently from a703c1b to 83d2cd6 Compare October 16, 2025 19:26
@feanil
feanil marked this pull request as ready for review October 17, 2025 13:53
@feanil
feanil requested a review from kdmccormick October 17, 2025 14:06
@feanil

feanil commented Oct 20, 2025

Copy link
Copy Markdown
Contributor Author

The last component that was using the studio frontend has now been removed also so this should be safe to land!

@feanil feanil added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Oct 20, 2025
@feanil
feanil force-pushed the feanil/drop_assets_and_files branch from 8af1c4c to f84341f Compare October 20, 2025 14:32
@feanil
feanil force-pushed the feanil/drop_studio_frontend_dependency branch from 83d2cd6 to 2c75b23 Compare October 20, 2025 14:33

@kdmccormick kdmccormick left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending a green build and some smoke testing, this looks good to me! 🔥 🔥 🔥

@open-craft-grove

Copy link
Copy Markdown

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Configuration information unavailable

1 similar comment
@open-craft-grove

Copy link
Copy Markdown

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Configuration information unavailable

@feanil
feanil force-pushed the feanil/drop_assets_and_files branch from f84341f to fcfa413 Compare October 20, 2025 15:50
@feanil

feanil commented Oct 20, 2025

Copy link
Copy Markdown
Contributor Author

Smoke testing looks good, I'll merge this later today after the last PR it depends on has landed on master.

Base automatically changed from feanil/drop_assets_and_files to master October 20, 2025 16:54
The dependencies on this package via studio should all be removed now
and so we no longer need to install this package to pickup any
components from it.

This work is part of:
* #36275
* #36108
Drop tooling to load studio-frontend components into mako templates and
XSS testing features related to it.
@feanil
feanil force-pushed the feanil/drop_studio_frontend_dependency branch from 2c75b23 to 28ab2ce Compare October 20, 2025 18:08
@feanil
feanil enabled auto-merge October 20, 2025 18:08
@feanil
feanil merged commit 23295c5 into master Oct 20, 2025
59 of 75 checks passed
@feanil
feanil deleted the feanil/drop_studio_frontend_dependency branch October 20, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

create-sandbox open-craft-grove should create a sandbox environment from this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants