Skip to content

Move waffle flags, configs to video service - #37631

Merged
farhan merged 1 commit into
masterfrom
farhan/add-waffle-flags
Nov 17, 2025
Merged

Move waffle flags, configs to video service#37631
farhan merged 1 commit into
masterfrom
farhan/add-waffle-flags

Conversation

@farhan

@farhan farhan commented Nov 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Ticket: #36282

@farhan
farhan force-pushed the farhan/add-waffle-flags branch from 7d1eeab to 7418e07 Compare November 14, 2025 07:05
@farhan
farhan marked this pull request as ready for review November 14, 2025 08:02
@farhan farhan added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Nov 14, 2025
@open-craft-grove

open-craft-grove commented Nov 14, 2025

Copy link
Copy Markdown

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@kdmccormick
kdmccormick self-requested a review November 14, 2025 16:21
@open-craft-grove

open-craft-grove commented Nov 14, 2025

Copy link
Copy Markdown

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

kdmccormick
kdmccormick approved these changes Nov 14, 2025
View reviewed changes

@kdmccormick kdmccormick left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small requests, but merge away once those are resolved 👍🏻

Comment thread xmodule/video_block/video_block.py Outdated
Comment thread xmodule/video_block/video_block.py Outdated
@open-craft-grove

open-craft-grove commented Nov 15, 2025

Copy link
Copy Markdown

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove

open-craft-grove commented Nov 15, 2025

Copy link
Copy Markdown

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@farhan
farhan force-pushed the farhan/add-waffle-flags branch from 7418e07 to 4df35f9 Compare November 17, 2025 09:30
@open-craft-grove

open-craft-grove commented Nov 17, 2025

Copy link
Copy Markdown

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@farhan
farhan merged commit a50ab7d into master Nov 17, 2025
53 checks passed
@farhan
farhan deleted the farhan/add-waffle-flags branch November 17, 2025 12:52
@farhan farhan mentioned this pull request Jan 23, 2026
Merged
2 tasks
anfbermudezme pushed a commit to Pearson-Advance/edx-platform that referenced this pull request Feb 16, 2026
@farhan @anfbermudezme
chore: Move waffle flags, configs (used in video block) to video service
8075a0d 
Merge pull request openedx#37631 from openedx/farhan/add-waffle-flags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kdmccormick kdmccormick kdmccormick approved these changes
@irtazaakram irtazaakram Awaiting requested review from irtazaakram irtazaakram is a code owner
@salman2013 salman2013 Awaiting requested review from salman2013 salman2013 is a code owner

Assignees

No one assigned

Labels

create-sandbox open-craft-grove should create a sandbox environment from this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@farhan @open-craft-grove @kdmccormick