You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The removal of un-used methods will decouple the Video Block with the edx-platform or content store.
It will make the Video Block extraction to xblocks-contrib easy. Ticket
History
Introduction of the method translation() method in video_handlers.py was first introduced used in this PR here while implementing bumper videos functionality.
Discountinue of the usage
While revamping the transcripts functionality in different phases it was removed in the PR here
Till then this method is unused, so this method and its relevant methods should be removed.
Testing Notes:
Video Block is working fine on the content-library/lms/studio.
Video Block editor is working fine on the content-library/lms/studio.
Testing Notes:
Here are the transcripts loading preview on the lms/studio/content-library
@farhan As per my understanding the code removal is related to transcripts but the testing description you mentioned looks generic for video block running, it would be good if you attach some running transcript results. Otherwise i believe PR looks fine. Thanks
Testing Notes:
Video Block is working fine on the content-library/lms/studio.
Video Block editor is working fine on the content-library/lms/studio.
@farhan As per my understanding the code removal is related to transcripts but the testing description you mentioned looks generic for video block running, it would be good if you attach some running transcript results. Otherwise i believe PR looks fine. Thanks
Testing Notes:
Video Block is working fine on the content-library/lms/studio.
Video Block editor is working fine on the content-library/lms/studio.
Thanks for the review, I have attached the screenshots of my testing on the local setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create-sandboxopen-craft-grove should create a sandbox environment from this PR
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused translation() method
Need of removing:
The removal of un-used methods will decouple the Video Block with the edx-platform or content store.
It will make the Video Block extraction to
xblocks-contribeasy. TicketHistory
Introduction of the method
translation()method in video_handlers.py was first introduced used in this PR here while implementing bumper videos functionality.Discountinue of the usage
While revamping the transcripts functionality in different phases it was removed in the PR here
Till then this method is unused, so this method and its relevant methods should be removed.
Testing Notes:
Testing Notes:
Here are the transcripts loading preview on the lms/studio/content-library