Skip to content

feat: apply ADRs to home v1 apis - #38694

Merged
Faraz32123 merged 3 commits into
openedx:feat/axim-api_improvementsfrom
edly-io:feat/contentstore_home_v1_adr_standardization
Jun 3, 2026
Merged

feat: apply ADRs to home v1 apis#38694
Faraz32123 merged 3 commits into
openedx:feat/axim-api_improvementsfrom
edly-io:feat/contentstore_home_v1_adr_standardization

Conversation

@taimoor-ahmed-1

@taimoor-ahmed-1 taimoor-ahmed-1 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Description

The FC-0118 initiative introduces a comprehensive standardization of APIs across the platform, guided by 15 newly defined Architectural Decision Records (ADRs). These ADRs collectively establish consistent patterns for serializers, permissions, error handling, pagination, filtering, authentication, versioning, and overall API design. Through this effort, existing endpoints are being refactored and aligned to ensure uniformity, improved developer experience, and long-term maintainability, while also reducing redundancy and inconsistencies across services.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 3, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @taimoor-ahmed-1!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Jun 3, 2026
@taimoor-ahmed-1
taimoor-ahmed-1 force-pushed the feat/contentstore_home_v1_adr_standardization branch from b49f284 to 4f8d8c3 Compare June 3, 2026 08:26
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Jun 3, 2026
@taimoor-ahmed-1 taimoor-ahmed-1 self-assigned this Jun 3, 2026
@taimoor-ahmed-1
taimoor-ahmed-1 force-pushed the feat/contentstore_home_v1_adr_standardization branch from 0a5bbbc to b307de9 Compare June 3, 2026 09:35
@Faraz32123
Faraz32123 force-pushed the feat/axim-api_improvements branch from 06b230b to 9a6856b Compare June 3, 2026 10:06
Taimoor Ahmed added 3 commits June 3, 2026 15:17
Wires HomeViewSet (v3) into openedx/core/lib/api/exceptions's
standardized_error_exception_handler via a v3-local StandardizedErrorMixin
that overrides DRF's per-view get_exception_handler. Project-wide
EXCEPTION_HANDLER setting is intentionally left unchanged so v0/v1/v2
endpoints are unaffected.
@Faraz32123
Faraz32123 merged commit cefdfe5 into openedx:feat/axim-api_improvements Jun 3, 2026
42 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Jun 3, 2026
Faraz32123 pushed a commit that referenced this pull request Jun 15, 2026
* feat: apply ADRs to home v1 apis

* feat: apply ADR 0029 error envelope to home v3 viewset

Wires HomeViewSet (v3) into openedx/core/lib/api/exceptions's
standardized_error_exception_handler via a v3-local StandardizedErrorMixin
that overrides DRF's per-view get_exception_handler. Project-wide
EXCEPTION_HANDLER setting is intentionally left unchanged so v0/v1/v2
endpoints are unaffected.

* feat: refactor mixin so that both v3 and v4 can use it
Faraz32123 pushed a commit that referenced this pull request Jun 15, 2026
* feat: apply ADRs to home v1 apis

* feat: apply ADR 0029 error envelope to home v3 viewset

Wires HomeViewSet (v3) into openedx/core/lib/api/exceptions's
standardized_error_exception_handler via a v3-local StandardizedErrorMixin
that overrides DRF's per-view get_exception_handler. Project-wide
EXCEPTION_HANDLER setting is intentionally left unchanged so v0/v1/v2
endpoints are unaffected.

* feat: refactor mixin so that both v3 and v4 can use it
Faraz32123 pushed a commit that referenced this pull request Jun 22, 2026
* feat: apply ADRs to home v1 apis

* feat: apply ADR 0029 error envelope to home v3 viewset

Wires HomeViewSet (v3) into openedx/core/lib/api/exceptions's
standardized_error_exception_handler via a v3-local StandardizedErrorMixin
that overrides DRF's per-view get_exception_handler. Project-wide
EXCEPTION_HANDLER setting is intentionally left unchanged so v0/v1/v2
endpoints are unaffected.

* feat: refactor mixin so that both v3 and v4 can use it
Faraz32123 pushed a commit that referenced this pull request Jun 24, 2026
* feat: apply ADRs to home v1 apis

* feat: apply ADR 0029 error envelope to home v3 viewset

Wires HomeViewSet (v3) into openedx/core/lib/api/exceptions's
standardized_error_exception_handler via a v3-local StandardizedErrorMixin
that overrides DRF's per-view get_exception_handler. Project-wide
EXCEPTION_HANDLER setting is intentionally left unchanged so v0/v1/v2
endpoints are unaffected.

* feat: refactor mixin so that both v3 and v4 can use it
feanil pushed a commit that referenced this pull request Jul 29, 2026
* feat: apply ADRs to home v1 apis

* feat: apply ADR 0029 error envelope to home v3 viewset

Wires HomeViewSet (v3) into openedx/core/lib/api/exceptions's
standardized_error_exception_handler via a v3-local StandardizedErrorMixin
that overrides DRF's per-view get_exception_handler. Project-wide
EXCEPTION_HANDLER setting is intentionally left unchanged so v0/v1/v2
endpoints are unaffected.

* feat: refactor mixin so that both v3 and v4 can use it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants