Skip to content

fix: platform-wide glob role assignments crash get_orgs_for_user/has_org_for_user - #38980

Open
efortish wants to merge 3 commits into
openedx:masterfrom
eduNEXT:ks/issue-380-platform-glob-org
Open

fix: platform-wide glob role assignments crash get_orgs_for_user/has_org_for_user#38980
efortish wants to merge 3 commits into
openedx:masterfrom
eduNEXT:ks/issue-380-platform-glob-org

Conversation

@efortish

@efortish efortish commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes openedx-authz#380

RoleBase._authz_get_orgs_for_user() (common/djangoapps/student/roles.py) reads assignment.scope.org for every AuthZ assignment. However, PlatformGlobData (the course-v1:* / lib:* platform-wide scopes) does not have an .org attribute, unlike CourseOverviewData / OrgGlobData, where .org is a valid (possibly None) field.

As a result, any user with a role assigned at a platform-wide scope would cause get_orgs_for_user() / has_org_for_user() to fail with an AttributeError.

The fix handles platform-wide assignments before accessing .org. Since a platform-wide grant applies to every organization, the compatibility layer returns all registered organization short names instead of trying to derive them from individual assignments.

Testing Instructions

  1. Enable the authz.enable_course_authoring flag globally.
  2. Assign a user a role at the platform-wide glob scope (course-v1:*).
  3. Call role.get_orgs_for_user(user) / role.has_org_for_user(user), or trigger any code path that uses them (e.g., the Studio course listing).
  4. Verify that all organizations are returned and no AttributeError is raised.

Added test_get_orgs_for_user_authz_platform_glob in common/djangoapps/student/tests/test_roles.py to cover this case.

…org_for_user

RoleBase._authz_get_orgs_for_user() read assignment.scope.org for every
AuthZ assignment, but PlatformGlobData (course-v1:*, lib:*) has no .org
attribute at all, unlike CourseOverviewData/OrgGlobData where it's a
real (possibly None) field. Any user with a platform-wide role crashed
get_orgs_for_user()/has_org_for_user() with an AttributeError.

Special-case platform-wide assignments: since they cover every org,
return all registered org short names instead of deriving them from
individual assignments.

Fixes openedx/openedx-authz#380
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 12, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @efortish!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform-oncall.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

get_orgs_for_user/has_org_for_user crash on platform-wide glob roles

2 participants