Add (currently failing) test case around saving metadata. - #514
Merged
Conversation
Contributor
There was a problem hiding this comment.
Wouldn't it be better to simply call super(ModuleStoreTestCase, self).setUp() rather than duplicating the logic here?
Contributor
Author
There was a problem hiding this comment.
This logic isn't present in ModuleStoreTestCase -- the behaviour we get by inheriting is setting up and tearing down the modulestore.
Contributor
There was a problem hiding this comment.
So, what do we gain by subclassing from ModuleStoreTestCase, then? Why not just subclass from unittest.TestCase?
Contributor
Author
There was a problem hiding this comment.
We get a unique modulestore collection in mongo, which will get cleaned up after the test is finished.
Contributor
|
Squash your commits down to one then 👍 by me. |
Contributor
Author
|
@sarina Danke, I'll just wait for tests to pass. |
peter-fogg
pushed a commit
that referenced
this pull request
Jul 29, 2013
Add (currently failing) test case around saving metadata.
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
…_sidebar adding the ability to override the sidebar name
Kelketek
referenced
this pull request
in open-craft/openedx-platform
Sep 17, 2015
Revert "Updated GP v1 notifications URL resolver to use new querystring attribute"
yoann-mroz
pushed a commit
to weuplearning/edx-platform
that referenced
this pull request
Nov 30, 2020
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
…penedx#514) Part 1 of REV-2130, Value Prop work
farhaanbukhsh
pushed a commit
that referenced
this pull request
Mar 20, 2023
fix: Fix retiring user auth models on disable event (Nutmeg backport)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sarina @singingwolfboy Tests Don's recent changes to xblock fields in #505. Will pass once merged with master.