Skip to content

Revert #3747 - #5355

Closed
singingwolfboy wants to merge 1 commit into
masterfrom
revert-pr-3747
Closed

Revert #3747#5355
singingwolfboy wants to merge 1 commit into
masterfrom
revert-pr-3747

Conversation

@singingwolfboy

Copy link
Copy Markdown
Contributor

#3747 caused LMS-11464, and since it didn't add any tests, it's too risky to go into the release.

This reverts commit 1955aade36675289bdbc01554b6f74242754a746.
@singingwolfboy singingwolfboy mentioned this pull request Sep 23, 2014
@jzoldak

jzoldak commented Sep 24, 2014

Copy link
Copy Markdown
Contributor

@singingwolfboy @sarina FYI.

I looked into the acceptance.tests.test_lms.LanguageTest test failures.

What these tests are doing is changing the user's preferred language from the default English to Dummy Esperanto, then confirming that the title label for the section of the student dashboard that shows all the courses that the student is enrolled in now contains "ÇØÜRSÉS" rather than being "CURRENT COURSES". (Technical aside - actually the text is the lowercase version of that string, styling uppercases its display in the browser).

This title string is defined in lms/templates/dashboard.html as a translated string. PR #3747 changed it from "Current Courses" to "Courses". We need to be sure that both the string and the applied translation are kept in step, otherwise these tests will fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants