Add donation button to the enrollment success message

[wedaly]

Changes:

• Add donation end-point
• Make donations configurable
• Added donation button to dashboard
• Generalize merchant defined data for payment processor

Notes:

• To enable this, you need to use model-based configuration. Enable DonationConfiguration and DashboardConfiguration (enrollment message timeout) in Django admin.
• This PR includes client-side validation and introduces a new client-side analytics event edx.bi.user.payment_processor.visited fired when the user clicks the "donate" button, right before we send them to the external payment processor.
• This PR does NOT include any style changes.

Reviewers: @dianakhuang @stephensanchez @AlasdairSwan
FYI: @andy-armstrong @chrisndodge

ECOM-445

[chrisndodge]

missing comma at end?

[wedaly]

Good catch! Fixed.

[chrisndodge]

@wedaly thanks for the tag.

After this gets merged in, it'll likely cause some merge conflicts in the shoppingcart djangoapp regarding what @asadiqbal08 @muhhshoaib are working on (cdodge/shopping-cart-rewrite). So they might need help resolving conflicts later on in this week.

[wedaly]

Couple of things I'm noticing while testing in a sandbox.

1. The new JS doesn't seem to be getting minified, despite going through the Django asset pipeline. @andy-armstrong is there something else I need to do to make this happen?

2. The client-side validation allows "0.00" as a valid donation amount, and the back-end has no problem sending that to CyberSource. I'm assuming we want to set a minimum amount and include client/server side validation. I'll coordinate with Griff to figure out what that amount should be.

[chrisndodge]

We do trap 0.00 value shopping carts in the views, but - yes - as you indicate, once it gets to CyberSource processors, there's no enforcement for a minimum value.

[stephensanchez]

just fyi you may be able to use locator.CourseLocator() instead of SlashSeparatedCourseKey (which I think is deprecated)

[dianakhuang]

Yup, SlashSeparatedCourseKey is deprecated, and I think it makes sense to fix it here.

[stephensanchez]

👍 looks really good.

[wedaly]

According to Griff and Manali, any amount > 0.00 is okay. Added client- and server-side validation for this edge case.

[andy-armstrong]

I like this convention in the absence of RequireJS. I think we'll adopt this on T&L too. @cahrens, what do you think?

[cahrens]

Yes, I like that as well.

[andy-armstrong]

I'm not a reviewer, but looks great to me. I'm really happy to see the excellent Jasmine tests.

[wedaly]

@andy-armstrong Thanks for the review. Updated with another commit to address your feedback, and I'll squash before merging.

[wedaly]

Rebased to get the enrollment messaging style changes @stephensanchez just merged.

[wedaly]

Updated to replace deprecated SlashSeparatedCourseKey in shoppingcart model tests.

[dianakhuang]

Question: are we expected to A/B test this at all? It seems a little weird to do that, but I figure it's worth asking.

[dianakhuang]

Otherwise, the code looks reasonable.

[stephensanchez]

I believe the AB testing got removed from the requirements.

On Tue, Oct 7, 2014 at 3:09 PM, Diana Huang notifications@github.com
wrote:

Otherwise, the code looks reasonable.

—
Reply to this email directly or view it on GitHub
https://github.com/edx/edx-platform/pull/5502#issuecomment-58242231.

[wedaly]

Thanks everyone for the quick reviews. @dianakhuang We're not going to A/B test this feature.