[TNL-730] View All Notes page. - #5968
Conversation
d7cfac1 to
2287c9d
Compare
cca3305 to
1cdf400
Compare
2287c9d to
097f52b
Compare
5e94581 to
0e0adc3
Compare
f98fcbb to
46b72ae
Compare
131ffaf to
37bfa69
Compare
There was a problem hiding this comment.
@polesye It should be descending not ascending.
There was a problem hiding this comment.
@polesye Actually, I take that back. Now that comparator has been removed from the notes collection, we are not testing ordering in Jasmine as per say. Just that the order in which models are added are unchanged in the rendering. So I would say
it('should display notes in the same order as they were added as well as their corresponding text and quote'...
There was a problem hiding this comment.
Actually, I take that back. Now that comparator has been removed from the notes collection, we are not testing ordering in Jasmine as per say. Just that the order in which models are added are unchanged in the rendering. So I would say
it('should display notes in the same order as they were added as well as their corresponding text and quote'...
Done.
|
@polesye Regarding the JS part 👍 when the above comments are addressed. |
|
@polesye because I can't save any notes in your sandbox, I can't actually see the Notes page with anything meaningful on it. Before I can thumbs up, I need to be able to see this. Is there anyway to hook up the backend so that we can save some notes and I can see the Notes page? @olmar or @tymofij ? |
There was a problem hiding this comment.
Seems docstring should be not in one line but formatted to a multi-line docstring:
"""
Displays the EdxNotes page.
"""
There was a problem hiding this comment.
Seems docstring should be not in one line but formatted to a multi-line docstring:
Done.
|
@polesye 👍 Once tests pass. |
There was a problem hiding this comment.
Please make multi-line docstring.
There was a problem hiding this comment.
Please make multi-line docstring.
Fixed.
There was a problem hiding this comment.
Please make multi-line docstring.
There was a problem hiding this comment.
Please make multi-line docstring.
Fixed.
|
@olmar your comments are addressed. |
48ab398 to
df04ec9
Compare
[TNL-730] View All Notes page.
5 participants
https://openedx.atlassian.net/browse/TNL-730
@tymofij , @olmar , @jmclaus please review.
sandbox: http://polesye.m.sandbox.edx.org/courses/edX/DemoX/Demo_Course/edxnotes