Upgrade: Font Awesome 4.2.0 - #6039
Conversation
14fae48 to
04be928
Compare
|
@clrux, here's a revised PR with one commit that contains all of our combined work. Mind taking a look and making sure you're cool with things I've done? @frrrances, mind manually reviewing the UI for Studio as well as the FED code? |
04be928 to
23ea821
Compare
|
Getting you folks a sandbox - should be up shortly. |
|
UPDATE: Sandbox has been created. @clrux, I also ran into a few rendering issues on the course outline (with my abstraction to having any edX-specific styling refer to a |
|
@talbs - testing on your sandbox I found a few small notes for the discussion forum. 1.) the new post button icon seems to have an alignment issue I don't see on production (though I'm not sure if it is something another branch in between our current release and this branch may have introduced.) (reference: https://www.dropbox.com/s/s8do1y6yj0zuq27/Screenshot%202014-11-24%2018.05.20.png?dl=0) I couldn't find anything else while testing the forums. Thanks for doing all of this work! Excited to be working on the latest font-awesome set. |
|
Reviewed Studio and found the following: Grading plus button is missing the icon - looks like an old cleanup may have affected this, but we can just go ahead and fix now: Icons are missing from the Course Announcements page (which may not be a bad thing): Alignment of edit icon on outline items on Outline page (which you guys already know): Contact Us button in the sock: That's all I got for this, though I found a bunch of other bugs/fixes I want to make now! |
|
@clrux, let's address the rest of the feedback on this branch/PR - https://github.com/edx/edx-platform/pull/6055. We'll merge that one in rather than this one which has some funky git commit stuff going on. Closing this with that in mind. |





This work updates our Font Awesome vendor files to the most recent version. This update required an expansive change in semantics and icon name references. A few notes:
.iconto any font awesome reference for our own additional styling/tweaking.