Skip to content

Upgrade: Font Awesome 4.2.0 - #6039

Closed
talbs wants to merge 7 commits into
masterfrom
talbs/update-font-awesome-4.2.0
Closed

Upgrade: Font Awesome 4.2.0#6039
talbs wants to merge 7 commits into
masterfrom
talbs/update-font-awesome-4.2.0

Conversation

@talbs

@talbs talbs commented Nov 24, 2014

Copy link
Copy Markdown
Contributor

This work updates our Font Awesome vendor files to the most recent version. This update required an expansive change in semantics and icon name references. A few notes:

  • On the Studio side, I've added a class of .icon to any font awesome reference for our own additional styling/tweaking.
  • Some icon names have changed or had to be replaced by similar icons
  • Reference templates, tests, as well as views have been updated

@talbs
talbs force-pushed the talbs/update-font-awesome-4.2.0 branch from 14fae48 to 04be928 Compare November 24, 2014 18:09
@talbs talbs changed the title WIP - Upgrade: Font Awesome to 4.2.0 (Cleaned Up) Upgrade: Font Awesome to 4.2.0 (Cleaned Up) Nov 24, 2014
@talbs

talbs commented Nov 24, 2014

Copy link
Copy Markdown
Contributor Author

@clrux, here's a revised PR with one commit that contains all of our combined work. Mind taking a look and making sure you're cool with things I've done?


@frrrances, mind manually reviewing the UI for Studio as well as the FED code?
@marcotuts, mind reviewing the forums UI manually to make sure we're not causing any issues?

@talbs
talbs force-pushed the talbs/update-font-awesome-4.2.0 branch from 04be928 to 23ea821 Compare November 24, 2014 21:30
@talbs

talbs commented Nov 24, 2014

Copy link
Copy Markdown
Contributor Author

Getting you folks a sandbox - should be up shortly.

@talbs talbs changed the title Upgrade: Font Awesome to 4.2.0 (Cleaned Up) Upgrade: Font Awesome to 4.2.0 Nov 24, 2014
@talbs talbs changed the title Upgrade: Font Awesome to 4.2.0 Upgrade: Font Awesome 4.2.0 Nov 24, 2014
@talbs

talbs commented Nov 24, 2014

Copy link
Copy Markdown
Contributor Author

UPDATE: Sandbox has been created.


@clrux, I also ran into a few rendering issues on the course outline (with my abstraction to having any edX-specific styling refer to a .icon class rather than font awesome specific ones). They mostly involve some inheritance issues with transitions/animations. Would you have tim e to proof and fix those issues?

@marcotuts

Copy link
Copy Markdown
Contributor

@talbs - testing on your sandbox I found a few small notes for the discussion forum.

1.) the new post button icon seems to have an alignment issue I don't see on production (though I'm not sure if it is something another branch in between our current release and this branch may have introduced.) (reference: https://www.dropbox.com/s/s8do1y6yj0zuq27/Screenshot%202014-11-24%2018.05.20.png?dl=0)
2.) rebuilding devstack now to test the discussion home grid alignment locally, although if you happen to have that enabled already that is the one area that might not have been proofed yet. https://www.dropbox.com/s/nfvdgmm3ibknvbe/Screenshot%202014-11-24%2018.10.07.png?dl=0
3.) on hover of the post type icons there seems to be a color change from blue to edx-merlot which isn't currently on production (reference while hovering on the first post:
image)

I couldn't find anything else while testing the forums. Thanks for doing all of this work! Excited to be working on the latest font-awesome set.

@frrrances

Copy link
Copy Markdown
Contributor

Reviewed Studio and found the following:

Grading plus button is missing the icon - looks like an old cleanup may have affected this, but we can just go ahead and fix now:

screen shot 2014-11-25 at 9 36 03 am

Icons are missing from the Course Announcements page (which may not be a bad thing):

screen shot 2014-11-25 at 9 32 21 am

Alignment of edit icon on outline items on Outline page (which you guys already know):

screen shot 2014-11-25 at 9 31 41 am

Contact Us button in the sock:

screen shot 2014-11-25 at 9 31 31 am

That's all I got for this, though I found a bunch of other bugs/fixes I want to make now!

@talbs

talbs commented Nov 25, 2014

Copy link
Copy Markdown
Contributor Author

@clrux, let's address the rest of the feedback on this branch/PR - https://github.com/edx/edx-platform/pull/6055. We'll merge that one in rather than this one which has some funky git commit stuff going on. Closing this with that in mind.

@talbs talbs closed this Nov 25, 2014
@downzer0
downzer0 deleted the talbs/update-font-awesome-4.2.0 branch January 8, 2015 14:17
@downzer0
downzer0 restored the talbs/update-font-awesome-4.2.0 branch January 8, 2015 14:17
@downzer0
downzer0 deleted the talbs/update-font-awesome-4.2.0 branch January 8, 2015 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants