Unit test speed improvements - #6111
Merged
Merged
Conversation
jzoldak
force-pushed
the
zoldak/modulestore-test-config
branch
from
December 3, 2014 16:51
92b4368 to
177fdbe
Compare
jzoldak
changed the title
jzoldak
force-pushed
the
zoldak/modulestore-test-config
branch
2 times, most recently
from
December 9, 2014 19:58
d27ea1b to
a69215f
Compare
added 2 commits
December 10, 2014 11:18
This should always be overridden by the testcases if needed.
jzoldak
force-pushed
the
zoldak/modulestore-test-config
branch
from
December 10, 2014 16:18
a69215f to
77bbd30
Compare
Contributor
Author
|
@clytwynec or @benpatterson please review |
Contributor
There was a problem hiding this comment.
Not a must: should these cleanup tasks also go in a tearDown method? (Or, be moved entirely to a tearDown method if state is clean enough for the first test?)
Contributor
Author
There was a problem hiding this comment.
No need. addCleanup replaces putting stuff in the tearDown.
Contributor
|
I had a question but changes LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should always be overridden by the testcases if needed.