Skip to content

Clytwynec/dont fail diff quality for todo #6122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clytwynec merged 1 commit into from
Dec 8, 2014
Merged

Clytwynec/dont fail diff quality for todo #6122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions pavelib/quality.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,14 +195,12 @@ def run_quality(options):
sh(
"{pythonpath_prefix} diff-quality --violations=pylint "
"{pylint_reports} {percentage_string} {compare_branch_string} "
"--html-report {dquality_dir}/diff_quality_pylint.html "
"--options='{pylint_options}'".format(
"--html-report {dquality_dir}/diff_quality_pylint.html ".format(
pythonpath_prefix=pythonpath_prefix,
pylint_reports=pylint_reports,
percentage_string=percentage_string,
compare_branch_string=compare_branch_string,
dquality_dir=dquality_dir,
pylint_options="--disable=fixme",
)
)
except BuildFailure, error_message:
Expand Down
3 changes: 3 additions & 0 deletions pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ disable=
# W0232: Class has no __init__ method
W0232,

# Disable 'fixme' so that quality builds don't fail due to them
W0511,

# Might use these when the code is in better shape
# C0302: Too many lines in module
# R0201: Method could be a function
Expand Down