WIP - Studio support for cohorted courseware - #6220
Closed
andy-armstrong wants to merge 10 commits into
Closed
Conversation
* removed summary header UI element * change "access" to "visibility" * change second radio element to "Specific Content Groups" * replaced key icon with eye icon * synced up specific visibility-related styling (sidebar + active icon state) * synced up all developer (NOTE: @andyarmstrong...) note mentions
Contributor
Author
|
@cahrens @dan-f @talbs Here's a very early cut at Studio support for cohorted courseware. I cherry picked @talbs's UX and then I've implemented a stubbed out visibility modal. The challenge is now how to get the visibility information into the modal. I'm going back and forth: is it better to do this server side as most of our other editors do, or should I do it in Backbone with an AJAX API. Any thoughts? |
Contributor
Author
|
FYI, the UX came from this PR: https://github.com/edx/edx-platform/pull/6095 |
…tain content groups. Tests still need to be written, and the class added to the "eye" icon on the component title bar.
andy-armstrong
changed the title
Contributor
Author
|
Closing this PR as it is against the wrong branch |
Contributor
|
Makes sense, thanks @andy-armstrong! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TNL-652