Skip to content

Fix email_opt_in_list export command to parse options correctly. - #6351

Merged
rocha merged 1 commit into
openedx:masterfrom
rocha:fix-email-opt-in-list-export-command
Jan 14, 2015
Merged

Fix email_opt_in_list export command to parse options correctly.#6351
rocha merged 1 commit into
openedx:masterfrom
rocha:fix-email-opt-in-list-export-command

Conversation

@rocha

@rocha rocha commented Dec 22, 2014

Copy link
Copy Markdown
Contributor

No description provided.

@rocha

rocha commented Dec 22, 2014

Copy link
Copy Markdown
Contributor Author

@dianakhuang @brianhw review please.

Because make_option was missing, django-admin was getting confused by the --courses argument.

I tried to write a test for it (using call_command) but it skips the django-admin parser. Other alternatives are a too elaborate.

@brianhw

brianhw commented Dec 23, 2014

Copy link
Copy Markdown
Contributor

I'll check with you tomorrow to understand the django-admin problem. Did this ever work?

@rocha

rocha commented Dec 23, 2014

Copy link
Copy Markdown
Contributor Author

@brianhw the make_option is required by the parser used in django-admin.py. The tests pass correctly, since they call the command without having to parse the arguments.

@rocha

rocha commented Jan 13, 2015

Copy link
Copy Markdown
Contributor Author

@dianakhuang @brianhw review please.

I thought we had merged this already. It is required to run the EmailOptInTask in the data exporter.

@brianhw

brianhw commented Jan 14, 2015

Copy link
Copy Markdown
Contributor

My apologies -- I also thought this was merged long ago. I'm assuming the test failure is unrelated. LGTM. 👍

@rocha

rocha commented Jan 14, 2015

Copy link
Copy Markdown
Contributor Author

@brianhw thanks. Yeah, the test error is from a flaky bok choy test.

@dianakhuang

Copy link
Copy Markdown
Contributor

👍

rocha added a commit that referenced this pull request Jan 14, 2015
Fix email_opt_in_list export command to parse options correctly.
@rocha
rocha merged commit 36813c0 into openedx:master Jan 14, 2015
@rocha
rocha deleted the fix-email-opt-in-list-export-command branch January 14, 2015 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants