Skip to content

Fix visual bug with large file error msg in cms. - #6385

Merged
singingwolfboy merged 1 commit into
openedx:masterfrom
ataki:ataki/gridfs-hotfix
Jan 14, 2015
Merged

Fix visual bug with large file error msg in cms.#6385
singingwolfboy merged 1 commit into
openedx:masterfrom
ataki:ataki/gridfs-hotfix

Conversation

@ataki

@ataki ataki commented Dec 29, 2014

Copy link
Copy Markdown
Contributor

This hotfix patches the functionality of the GridFS PR described by @sarina here: https://github.com/edx/edx-platform/pull/5731 by dismissing the error msg when the user uploads a large file and fails, then uploads a regular file. This includes a Jasmine test to cover this case.

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @ataki! I've created OSPR-324 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ('this must be merged by XX date', and why that is)
  • partner information ('this is a course on edx.org')
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the Github pull request interface. As a reminder, our process documentation is here.

@singingwolfboy

Copy link
Copy Markdown
Contributor

Hey @ataki, we had an issue on the master branch recently, which seems to have caused some problems with the commits on this pull request. Can you rebase your pull request so that the extra commits no longer show up?

@ataki

ataki commented Dec 30, 2014

Copy link
Copy Markdown
Contributor Author

sure, just rebased on top of master as of 12/29

This hotfix patches the functionality of the GridFS PR
by dismissing the error msg when the user uploads a large
file and fails, then uploads a regular file. This
includes a Jasmine test to cover this case.
@singingwolfboy

Copy link
Copy Markdown
Contributor

Hey, sorry for the delay on this. I just manually tested your pull request, and it works great! Thanks!

singingwolfboy added a commit that referenced this pull request Jan 14, 2015
Fix visual bug with large file error msg in cms.
@singingwolfboy
singingwolfboy merged commit df5dd1a into openedx:master Jan 14, 2015
@ataki
ataki deleted the ataki/gridfs-hotfix branch January 14, 2015 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants