Aamir khan/ecom 528 donation verified courses - #6521
Merged
aamir-khan merged 11 commits intoJan 12, 2015
Conversation
…ified-courses' into aamir-khan/ECOM-528-donation-verified-courses Conflicts: common/djangoapps/student/tests/test_recent_enrollments.py
Contributor
There was a problem hiding this comment.
Be sure to remove commented out code before merging in
Contributor
There was a problem hiding this comment.
Style nitpick: please add a space between "#" and "Register" in each of these comments.
Also, we use "register" to mean "a user has created an account". This is different from "enroll", which means, "a user has enrolled in a course". So I think these comments should say "enroll" instead of "register".
Contributor
|
Two small comments, otherwise looks good to me! 👍 Please squash commits before merging. |
Contributor
|
👍 |
aamir-khan
added a commit
that referenced
this pull request
Jan 12, 2015
…ed-courses Aamir khan/ecom 528 donation verified courses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP @wedaly @stephensanchez Please review this PR