Skip to content

Fix bug when deleting first of two recently added blocks - #6580

Merged
antoviaque merged 1 commit into
openedx:content-librariesfrom
open-craft:content_libraries/20-bugfix
Jan 13, 2015
Merged

Fix bug when deleting first of two recently added blocks#6580
antoviaque merged 1 commit into
openedx:content-librariesfrom
open-craft:content_libraries/20-bugfix

Conversation

@e-kolpakov

Copy link
Copy Markdown
Contributor

Background: This PR fixes an issue with editing a library. Before the fix, due to differences between expected and actual DOM structure, XBlocks were sometimes added inside sibling XBlocks' wrapper elements.
JIRA ticket: https://openedx.atlassian.net/browse/OSPR-347
Discussions: Architecture discussed extensively on the wiki and in meetings, then the revised proposal was presented to the Arch Council on Oct. 21 and given thumbs up.
Sandbox URL: LMS at http://content-libraries.sandbox.opencraft.com/ and Studio at http://content-libraries.sandbox.opencraft.com:18010/
Partner information: 3rd party-hosted open edX instance, for an edX solutions client.

Testing instructions:

  • Create a new empty library
  • Add Blank Common Problem
  • Add Checkboxes
  • Delete the Blank Common Problem
  • Checkboxes block should not disappear.

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @e-kolpakov! It looks like you're a member of a company that does contract work for edX. If you're doing this work as part of a paid contract with edX, you should talk to edX about who will review this pull request. If this work is not part of a paid contract with edX, then you should ensure that there is an OSPR issue to track this work in JIRA, so that we don't lose track of your pull request.

To automatically create an OSPR issue for this pull request, just visit this link: http://openedx-webhooks.herokuapp.com/github/process_pr?number=6580&repo=edx%2Fedx-platform

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @e-kolpakov! I've created OSPR-347 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ('this must be merged by XX date', and why that is)
  • partner information ('this is a course on edx.org')
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the Github pull request interface. As a reminder, our process documentation is here.

@openedx-webhooks

Copy link
Copy Markdown

Hello @e-kolpakov: We are unable to continue with review of your submission at this time. Please see the associated JIRA ticket for more explanation.

@antoviaque

Copy link
Copy Markdown
Contributor

@e-kolpakov Closed the Jira ticket - this should have been a solutions jira ticket.

But to complete the final review in one place, I'm going to merge this into the current https://github.com/edx/edx-platform/pull/6459 MVP PR, along with the two other small fixes from @bradenmacdonald yesterday. Can you squash your commits? Thanks!

@e-kolpakov
e-kolpakov force-pushed the content_libraries/20-bugfix branch from 5c10f8e to 9f6cf15 Compare January 13, 2015 10:50
@antoviaque
antoviaque merged this pull request into openedx:content-libraries Jan 13, 2015
@sarina sarina added the open-source-contribution PR author is not from Axim or 2U label Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs triage open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants