FIX - Studio: resolving xblock warning messages icons - #6607
Merged
Conversation
Contributor
Author
|
@cahrens, here's the quick fix to the issue you brought up a bit ago. I'm getting a sandbox set up now which should be available at http://studio.fa-xblockwarnings.m.sandbox.edx.org shortly. I'll import a course with the warning once its up for verification. FWIW, If you don't need that level of review, feel free to thumbs this earlier to get it merged earlier. FYI, @explorerleslie. |
Contributor
Author
|
@cahrens and @explorerleslie, sandbox is up and here's a unit with the fix displayed - http://studio.fa-xblockwarnings.m.sandbox.edx.org/container/i4x://TestU/test-001/vertical/272c042c5af14dec81f841364f46c9f4 |
|
👍 Did you check if the error state (red triangle?) is correctly colored? |
Contributor
Author
|
@cahrens, yep - that was already covered. Thanks! |
talbs
added a commit
that referenced
this pull request
Jan 14, 2015
…tawesome FIX - Studio: resolving xblock warning messages icons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work resolves an icon styling issue with xblock warning messages