Make split mongo read-only API consistent with other modulestores. - #667
Conversation
|
@dmitchell please review |
There was a problem hiding this comment.
Should perhaps check that location.category == 'course' otherwise the course_id is not really the course_id. I was actually wondering whether we should change the course_id property to error if the locator is not a course.
There was a problem hiding this comment.
I am throwing an exception now in location.course_id if category is not 'course'. Also added unit test for it.
|
Looks reasonable. I haven't thought whether this is complete. 👍 |
There was a problem hiding this comment.
This is going to be a problem for MixedModuleStore
…plementation). Also clarifies the contraction of location.course_id by throwing an exception for lcoations that are not of category course. Add test for course_id method.
|
@chrisndodge @dmitchell Please review again. I put get_errored_courses into ModuleStoreBase and changed to throwing InvalidLocationException in location.course_id if location is not of category 'course'. |
Make split mongo read-only API consistent with other modulestores.
Update user detail API to add last_login
Revert merge 657 commits
* [feat] MICROBA-1523 Add notices redirect to learning MFE To support the notices plugin on platform, this adds a redirect to the course home page. If a user lands on that page and has not acknowledged a notice, the user will be redirected to notice instead of the course home.
This incorporates some material removed in commit 9a94a27, added to the Variations section and a new Notices section in the main README.
https://edx-wiki.atlassian.net/browse/STUD-617
Some details: