Skip to content

Upgrade: Font Awesome 4.3.0 - #6875

Merged
talbs merged 1 commit into
masterfrom
talbs/update-font-awesome-4.3
Feb 5, 2015
Merged

Upgrade: Font Awesome 4.3.0#6875
talbs merged 1 commit into
masterfrom
talbs/update-font-awesome-4.3

Conversation

@talbs

@talbs talbs commented Feb 3, 2015

Copy link
Copy Markdown
Contributor

This work upgrades Font Awesome (http://fontawesome.io/) vendor files from 4.2.0 to 4.3.0. There are no large syntax changes as part of this and all current icons should be supported as they had been with 4.2.0. This will merely give us the updated icon catalog to use.

Sandbox apps:

@talbs
talbs force-pushed the talbs/update-font-awesome-4.3 branch from 555948d to 9b802f3 Compare February 3, 2015 18:22
@talbs

talbs commented Feb 3, 2015

Copy link
Copy Markdown
Contributor Author

@clrux and @AlasdairSwan, mind reviewing this quick upgrade to Font Awesome? I've set up a sandbox (http://fontawesome.m.sandbox.edx.org/ and http://studio.fontawesome.m.sandbox.edx.org/) for end UI testing.


FYI, @feanil

@downzer0

downzer0 commented Feb 3, 2015

Copy link
Copy Markdown
Contributor

@talbs Has the Settings view always looked like the below?
screen shot 2015-02-03 at 2 50 21 pm

The labels and checkboxes are on different lines.

Other than that, things appear OK.

@talbs

talbs commented Feb 3, 2015

Copy link
Copy Markdown
Contributor Author

@clrux, what URL are you hitting to get to that view?

@talbs
talbs force-pushed the talbs/update-font-awesome-4.3 branch from 9b802f3 to 89a05d8 Compare February 3, 2015 20:21
@downzer0

downzer0 commented Feb 3, 2015

Copy link
Copy Markdown
Contributor

@talbs

talbs commented Feb 3, 2015

Copy link
Copy Markdown
Contributor Author

@clrux, just confirmed that this wiki post settings UI looks the same on staging (also, the UI doesn't have much to do with Font Awesome changes). Here's a screengrab...

screen shot 2015-02-03 at 3 34 28 pm

@downzer0

downzer0 commented Feb 3, 2015

Copy link
Copy Markdown
Contributor

Cool. Then 👍 from me.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the no transform here?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh duh. vendor file. please ignore.

@frrrances

Copy link
Copy Markdown
Contributor

Looks good to me. 👍

@AlasdairSwan

Copy link
Copy Markdown
Contributor

@talbs are there any verified courses on that sandbox? I need to see the verification flow to see any of the icon fonts :)

@talbs

talbs commented Feb 5, 2015

Copy link
Copy Markdown
Contributor Author

@AlasdairSwan, I do not - do you have one I can import or instructions on how to set one up if its outside of a simple Studio course import?

@AlasdairSwan

Copy link
Copy Markdown
Contributor

@talbs I ran it locally and it's looking good 👍

talbs added a commit that referenced this pull request Feb 5, 2015
@talbs
talbs merged commit 5785df2 into master Feb 5, 2015
@talbs
talbs deleted the talbs/update-font-awesome-4.3 branch February 5, 2015 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants