Skip to content

Benp/static code analysis radon - #7147

Merged
benpatterson merged 3 commits into
masterfrom
benp/static-code-analysis-radon
Mar 5, 2015
Merged

Benp/static code analysis radon#7147
benpatterson merged 3 commits into
masterfrom
benp/static-code-analysis-radon

Conversation

@benpatterson

Copy link
Copy Markdown
Contributor

No description provided.

@benpatterson
benpatterson force-pushed the benp/static-code-analysis-radon branch from 4252d8d to 471bd2c Compare February 27, 2015 12:02
@benpatterson

Copy link
Copy Markdown
Contributor Author

@clytwynec @jzoldak

Comment thread scripts/all-tests.sh Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to either get picked up as a build artifact or displayed on the console, otherwise you don't ever see the result in an actual build.
E.g. the quality subset for the last commit on the branch.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Along those lines, have you looked into the --xml option? The documentation suggests that it works with a Jenkins plugin to report them.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did glance at that, but didn't consider the plugin. Basically in terms of output, we can get an overall score, or we can get a full report for everything. I had looked at ways of capturing complexity on your diff (can't use diff-quality for it because it considers the whole method/class/etc). But ultimately I thought a straight text report, which includes a total score at the end, would be easiest, esp when thinking of an eventual move to Travis.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

@benpatterson
benpatterson force-pushed the benp/static-code-analysis-radon branch from 9a23914 to eb4f852 Compare March 2, 2015 21:03
@benpatterson

Copy link
Copy Markdown
Contributor Author

@jzoldak I've adjusted the location of the report so that it's collected after a build. Here's an example: https://build.testeng.edx.org/job/edx-platform-all-tests-pr-flow/822/artifact/reports/code_complexity.log/*view*/

You can see the 'total average' score at the end. We can further filter the report to only provide the total average, but I thought for starters, it may be useful to have the entire report.

@benpatterson

Copy link
Copy Markdown
Contributor Author

@feanil @maxrothman @fredsmith could one of you fellas take a look at adding this library from the DevOps perspective?

@clytwynec

Copy link
Copy Markdown
Contributor

👍 from my perspective

@jzoldak

jzoldak commented Mar 4, 2015

Copy link
Copy Markdown
Contributor

👍 from me too.

@feanil

feanil commented Mar 4, 2015

Copy link
Copy Markdown
Contributor

👍

benpatterson pushed a commit that referenced this pull request Mar 5, 2015
@benpatterson
benpatterson merged commit 1d00508 into master Mar 5, 2015
@benpatterson
benpatterson deleted the benp/static-code-analysis-radon branch March 5, 2015 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants