Implement full preferences API - #7327
Merged
Merged
Conversation
Author
There was a problem hiding this comment.
It's interesting that the default value for is_active is True (though when an account is created, it does end up being false, if you look above at AccountSettingsOnCreationTest.
Merged
Contributor
|
@cahrens @jimabramson the preferences API is ready for review. @wedaly could you also look at this since we've refactored some of DedX's APIs. |
andy-armstrong
force-pushed
the
andya/preferences-api
branch
from
March 13, 2015 15:09
40a8aae to
634bb98
Compare
Author
There was a problem hiding this comment.
This needs to be updated to UserNotFound.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://openedx.atlassian.net/browse/TNL-1493
Replaces #7279.