Account settings page - #7335
Conversation
dcc122c to
6d7372e
Compare
|
@explorerleslie @catong @marcotuts The sandbox should meet all the requirements now. Please review: http://learnerprofile.m.sandbox.edx.org/ |
|
@symbolist, please tag @srpearce. She is the writer for this feature and should also be tagged for any doc strings/UI review. Thanks! |
There was a problem hiding this comment.
This should have its own section outside of the //shared - course area I think. I would make a "// views - platform" section underneath shared - course
Additionally, this import might make sense to add to application-extend2.scss.mako since that's where the other platform level views are imported.
36448eb to
ec538e7
Compare
58604c6 to
292556e
Compare
There was a problem hiding this comment.
anytime there's a math operation on a css variable, our convention is to wrap these in parentheses. ($baseline*2) I'll note this when I see it on this PR.
ec538e7 to
acb59d2
Compare
|
@catong @explorerleslie @marcotuts Sandbox is back up: http://userprofile.m.sandbox.edx.org/account/settings |
|
@symbolist where is the list of languages that you're using come from? is it a default python library? I'd prefer a list the same as the one we use in video transcript language selection:
|
acb59d2 to
6f7c590
Compare
|
@symbolist I see languages like LOLCATS, Pirate, and Dummy Language on the account settings page that aren't in the list that you sent me. Why is that? Can we use the same list as in Studio? |
|
@symbolist I continued my styling / FED feedback through this PR / branch - https://github.com/edx/edx-platform/pull/7400 In summary, the suggested changes including some naming conventions for class names, table of contents comments for the scss file, text alignment for the fields even in case of longer support strings, and the use of borders as visual separators instead of tags |
|
@cptvitamin could you please do an accessibility review? Sandbox is http://userprofile.m.sandbox.edx.org/account/settings. |
There was a problem hiding this comment.
this <label> element is not programmatically associated with the form field it relates to. Either the form field needs to be a child of the <label> or the <label> element needs a for= attribute that references the ID of the associated form field. Also, the <label> needs to be associated with the *field-message span that follows with an aria-describedby= attribute that references an ID associated with that <span>
|
@symbolist @explorerleslie, I did a first pass at an accessibility review. Would love another pass at it once these changes are implemented. |
TNL-1759
3acba0d to
3b37766
Compare
|
@andy-armstrong eventing test failure caused by change to default being "all_users". https://build.testeng.edx.org/job/edx-platform-all-tests-pr-flow/4160/testReport/junit/acceptance.tests.lms.test_learner_profile/DifferentUserLearnerProfilePageTest/test_different_user_private_profile/ |
…anup Removed all references to AUTH_ENTRY_DASHBOARD.
TNL-1862
Verify i18n
db9f4ba to
bb083b5
Compare
bb083b5 to
5085f94
Compare
|
There was a strange acceptance failure here so I'm going to kick off another build: 19:12:11 ERROR:util.models:String decompression failed. There may be corrupted data in the database: Incorrect padding https://build.testeng.edx.org/job/edx-platform-test-subset/40023/console |
|
Jenkins, please test this |
|
Jenkins, test this please |
|
All tests have passed, merging! |
|
Yay! |
|
Look, it's a green checkmark!! |
11 participants
https://openedx.atlassian.net/browse/TNL-1499
https://openedx.atlassian.net/browse/TNL-1534
The "Connected Accounts" functionality will be implemented in a separate PR.