Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cms/envs/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -799,6 +799,7 @@

OPTIONAL_APPS = (
'mentoring',
'problem_builder',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bradenmacdonald You will also need to add it to https://github.com/edx/edx-platform/blob/97f0cf108f6bd96ad678c6b3a168163f179e3e7d/cms/envs/common.py#L856 to allow it to be addable to a unit, this only allows to get the migrations to run.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antoviaque Ah, thanks - good catch.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be added to the LMS as well?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it matters, because all we need is for the tables to be created, and the cms and lms migrations are usually run together as part of paver update_db. But since the old mentoring was listed in both, and it could potentially be important in the future, I might as well add it in there too.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I added it to the lms/envs/common.py. I just amended the commit with that one-line change.

'edx_sga',

# edx-ora2
Expand Down Expand Up @@ -863,6 +864,8 @@
'lti',
'library_content',
'edx_sga',
'problem-builder',
'pb-dashboard',
# XBlocks from pmitros repos are prototypes. They should not be used
# except for edX Learning Sciences experiments on edge.edx.org without
# further work to make them robust, maintainable, finalize data formats,
Expand Down
1 change: 1 addition & 0 deletions lms/envs/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -2100,6 +2100,7 @@
### Apps only installed in some instances
OPTIONAL_APPS = (
'mentoring',
'problem_builder',
'edx_sga',

# edx-ora2
Expand Down
2 changes: 1 addition & 1 deletion requirements/edx/edx-private.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

# For Harvard courses:
-e git+https://github.com/gsehub/xblock-mentoring.git@4d1cce78dc232d5da6ffd73817b5c490e87a6eee#egg=xblock-mentoring
-e git+https://github.com/open-craft/problem-builder.git@700f1834c0e8249ce9273c58ad074a1391939cd5#egg=xblock-problem-builder
-e git+https://github.com/open-craft/problem-builder.git@4817f9d93f8ce07bbe496f4e1681450f26ef9d19#egg=xblock-problem-builder

# Prototype XBlocks from edX learning sciences limited roll-outs and user testing.
# Concept XBlock, in particular, is nowhere near finished and an early prototype.
Expand Down